From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f174.google.com (mail-pf0-f174.google.com
 [209.85.192.174]) by dpdk.org (Postfix) with ESMTP id 6B37E2BD9
 for <dev@dpdk.org>; Wed, 30 Mar 2016 18:41:51 +0200 (CEST)
Received: by mail-pf0-f174.google.com with SMTP id 4so47254318pfd.0
 for <dev@dpdk.org>; Wed, 30 Mar 2016 09:41:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=QYQRmGqXetac+JBnZFhIKwO0eGU07rgqtL0H/491Hfw=;
 b=UQq37mN0lH7lmvdYqY4JljPR6omjW2V7o84M37cCbpVHWVQOqJbzxnqvCp+RdZ5kHQ
 udxpYA1dCUkCFJiz9I23urD/KD7lawfzPqsW0jy5XvCM0b8GFL+/bH7wwmkDRP7XzTgR
 EYQj5Cz+mWSCi7CbP/CnxcndA9ie8WkGqIqgWWl2r636CRuYTYiRHjv+oUML3o7esFKK
 o0SCAhRYmcmAtzO+BeFW2lFeJcKUypPPGa/5yScUdFedBsRj6DYuE/sq30Oz1bYhGx+O
 QvhM38LnSL32eIXcFEOGRTgUX939wF3KFCGUt4NUF5mkJwKoVY7F2BA07d/mwOEHsdVK
 0vyA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=QYQRmGqXetac+JBnZFhIKwO0eGU07rgqtL0H/491Hfw=;
 b=f/4Nmtk9RNraEDvFqmxFRgt1HcdvT/areNCSIkZM95pPJqDvjU7rh+7ia4oR8Yi+HT
 VEPfNORZ4s5NBXiLaeCwhgbXa620x6NAIhjthrX0rspN9PL2d24SR3MKhXSk1xVzT2uW
 Sopk/r/1JLlAf45WCZWscY5tAsj9MQqUhHITKlNs5T3/fAWL5teGbEi0pez1zHokIJit
 e4hRXuchzlc6b//VGk5+HbIzhynIMbQjCxVaD4/0gAJpLsq7r9hfTK47KKuG6+DsVu8i
 yXu82d368Lkaww1HRVr3g4TKvEF9Xl/C4TkLPwOT7644nqgxp5sV+USmygwYwRMz3PfJ
 bPfg==
X-Gm-Message-State: AD7BkJI+PMyRJHuMyNlRFm6Ipz3EgEQLtuxkOkeCjznmR9z+bB8L1oY/GaG/rTLAKj70Fw==
X-Received: by 10.98.73.142 with SMTP id r14mr14777071pfi.140.1459356110874;
 Wed, 30 Mar 2016 09:41:50 -0700 (PDT)
Received: from xeon-e3 (static-50-53-73-178.bvtn.or.frontiernet.net.
 [50.53.73.178])
 by smtp.gmail.com with ESMTPSA id ko9sm7144682pab.37.2016.03.30.09.41.50
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 30 Mar 2016 09:41:50 -0700 (PDT)
Date: Wed, 30 Mar 2016 09:42:06 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: <bruce.richardson@intel.com>, <thomas.monjalon@6wind.com>,
 <dev@dpdk.org>, <ameen.rahman@qlogic.com>, <harish.patil@qlogic.com>,
 <sony.chacko@qlogic.com>
Message-ID: <20160330094206.65eae5a8@xeon-e3>
In-Reply-To: <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com>
References: <1459315705-25001-1-git-send-email-rasesh.mody@qlogic.com>
 <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 05/10] qede: Add core driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Mar 2016 16:41:51 -0000

On Tue, 29 Mar 2016 22:28:20 -0700
Rasesh Mody <rasesh.mody@qlogic.com> wrote:

> +static int qede_dev_configure(struct rte_eth_dev *eth_dev)
> +{
> +	struct qede_dev *qdev = eth_dev->data->dev_private;
> +	struct ecore_dev *edev = &qdev->edev;
> +	struct rte_eth_rxmode *rxmode = &eth_dev->data->dev_conf.rxmode;
> +	int rc = 0;

Looks like rc was set but never used here.