Re: [dpdk-dev] [PATCH v4 05/10] qede: Add core driver

[Stephen Hemminger <stephen@networkplumber.org>]

On Tue, 29 Mar 2016 22:28:20 -0700
Rasesh Mody <rasesh.mody@qlogic.com> wrote:

> +
> +static void
> +qede_dev_info_get(struct rte_eth_dev *eth_dev,
> +		  struct rte_eth_dev_info *dev_info)
> +{
> +	struct qede_dev *qdev = eth_dev->data->dev_private;
> +	struct ecore_dev *edev = &qdev->edev;
> +
> +	PMD_INIT_FUNC_TRACE(edev);
> +
> +	dev_info->min_rx_bufsize = (uint32_t)(ETHER_MIN_MTU +
> +					      QEDE_ETH_OVERHEAD);
> +	dev_info->max_rx_pktlen = (uint32_t)ETH_TX_MAX_NON_LSO_PKT_LEN;
> +	dev_info->rx_desc_lim = qede_rx_desc_lim;
> +	dev_info->tx_desc_lim = qede_tx_desc_lim;
> +	/* Fix it for 8 queues for now */
> +	dev_info->max_rx_queues = 8;
> +	dev_info->max_tx_queues = 8;
> +	dev_info->max_mac_addrs = (uint32_t)(RESC_NUM(&edev->hwfns[0],
> +						      ECORE_MAC));
> +	dev_info->max_vfs = (uint16_t)NUM_OF_VFS(&qdev->edev);
> +	dev_info->driver_name = qdev->drv_ver;
> +	dev_info->reta_size = ETH_RSS_RETA_SIZE_128;
> +	dev_info->flow_type_rss_offloads = (uint64_t)QEDE_RSS_OFFLOAD_ALL;
> +	dev_info->default_txconf = (struct rte_eth_txconf) {
> +	.txq_flags = QEDE_TXQ_FLAGS,};

Please indent this initialization, like other drivers
	dev_info->default_txconf = (struct rte_eth_txconf) {
		.txq_flags = QEDE_TXQ_FLAGS,
	};