From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id DBE0312A8 for ; Wed, 30 Mar 2016 18:43:15 +0200 (CEST) Received: by mail-pa0-f41.google.com with SMTP id zm5so45126169pac.0 for ; Wed, 30 Mar 2016 09:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b7Je5MLO8IXk3wzUvE4RsNWUlhiPim+V8OO2NsryBdE=; b=pSGpn7VQ2MFeUhM3SQz4k1KBaXdH51Q4EUu34Wg+jwePM18rRyqahaa6l3jvjt+6ee sFlDz5s9U6+dbKVO2Gooo7Uq04GSRKrGGLTDH3st8YHRNEFN0FQWkngxETtvcw1bfGAG RA4WwZPA6aL622HYWF03QvSEhtFxRoqiWHWlJCX/xp8UiIDrDx4Jqe3RPENqPtwaOh8f MaJTIgCVFy/styTPKHOM/aKfl+Yd0Oyo14GMQzSbRtF2ltK2vgvK1Osg/u6DP515Zr3X vyZUCfqJR1y3v4Wdf48YfDJ+A1m1gyW0MR4aCVgk1iVMzkLGN4zQN9ZekQjsOlwifwSi akfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b7Je5MLO8IXk3wzUvE4RsNWUlhiPim+V8OO2NsryBdE=; b=UFYOW4hENIrX0n+qOYTVR3ZpvFxAkIt9azsmS64kfn0q/xGuN4lSTgrA8sZzgvl+np fxQf0lcjbe4BBr/ukRybp7krPkEh0NB81WtpEs5ZhoqDijzdaH0ko4loiuR23pplCANF exyIX1lEZrhXcHRkrDBWVQa+mghy18H/3H0bY+DwBYOeECoZA9RAv+bqCLeYWEUiUTep uC/LayKi2Tm+2CiwnBrh/g5fEQQMpenjcyd6NsZffKX1TfsK0JrpN3XooxEU5jTjKt/T 9sEaEDKw4qPzn4GT7aboOexu9jBSOMqeGUt9+BQmZ4AqsraWwvHpoynbigqSTQMO4xDi K4yQ== X-Gm-Message-State: AD7BkJL652cuBFu5baLrPrvap8SzRvf4aIKw5b3MgztuCzYwq+5kP3l1TFAU8JjhbaG6PQ== X-Received: by 10.66.138.74 with SMTP id qo10mr8778255pab.140.1459356195348; Wed, 30 Mar 2016 09:43:15 -0700 (PDT) Received: from xeon-e3 (static-50-53-73-178.bvtn.or.frontiernet.net. [50.53.73.178]) by smtp.gmail.com with ESMTPSA id q4sm7119066pfi.94.2016.03.30.09.43.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Mar 2016 09:43:15 -0700 (PDT) Date: Wed, 30 Mar 2016 09:43:31 -0700 From: Stephen Hemminger To: Rasesh Mody Cc: , , , , , Message-ID: <20160330094331.6650fc7f@xeon-e3> In-Reply-To: <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com> References: <1459315705-25001-1-git-send-email-rasesh.mody@qlogic.com> <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 05/10] qede: Add core driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2016 16:43:16 -0000 On Tue, 29 Mar 2016 22:28:20 -0700 Rasesh Mody wrote: > + > +static void > +qede_dev_info_get(struct rte_eth_dev *eth_dev, > + struct rte_eth_dev_info *dev_info) > +{ > + struct qede_dev *qdev = eth_dev->data->dev_private; > + struct ecore_dev *edev = &qdev->edev; > + > + PMD_INIT_FUNC_TRACE(edev); > + > + dev_info->min_rx_bufsize = (uint32_t)(ETHER_MIN_MTU + > + QEDE_ETH_OVERHEAD); > + dev_info->max_rx_pktlen = (uint32_t)ETH_TX_MAX_NON_LSO_PKT_LEN; > + dev_info->rx_desc_lim = qede_rx_desc_lim; > + dev_info->tx_desc_lim = qede_tx_desc_lim; > + /* Fix it for 8 queues for now */ > + dev_info->max_rx_queues = 8; > + dev_info->max_tx_queues = 8; > + dev_info->max_mac_addrs = (uint32_t)(RESC_NUM(&edev->hwfns[0], > + ECORE_MAC)); > + dev_info->max_vfs = (uint16_t)NUM_OF_VFS(&qdev->edev); > + dev_info->driver_name = qdev->drv_ver; > + dev_info->reta_size = ETH_RSS_RETA_SIZE_128; > + dev_info->flow_type_rss_offloads = (uint64_t)QEDE_RSS_OFFLOAD_ALL; > + dev_info->default_txconf = (struct rte_eth_txconf) { > + .txq_flags = QEDE_TXQ_FLAGS,}; Please indent this initialization, like other drivers dev_info->default_txconf = (struct rte_eth_txconf) { .txq_flags = QEDE_TXQ_FLAGS, };