From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com
 [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id B4F9A12A8
 for <dev@dpdk.org>; Wed, 30 Mar 2016 18:45:21 +0200 (CEST)
Received: by mail-pa0-f41.google.com with SMTP id zm5so45161046pac.0
 for <dev@dpdk.org>; Wed, 30 Mar 2016 09:45:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=T1HaJuokhMjgl1Nju0e+RrNTBPvUpx6J33EHmxuUKU8=;
 b=Lzch5RBSeNQbUdQQCP1qc3KikKPCYZE+ZpMuu/J2b7a2qTyu6gMt3zYoQ7dYEjyCt5
 zU1Odw97KUYCQBtoSmsnmjyaGic26zwufdy15DL1JUlrvzTjB0pwLojMQsuO1M5rjOl8
 5HZ1U4Ulpw8oAim1tSt37SGFlo7Yokzp/p1gFBpiuaIO71of3mTIBKQ5wiFiz8wrNVEb
 XoSSuCvPD4BYn8XO1CuXZ5siXIIntslnKX8wB9nmSwQdG+fJWBg2cg+XUTfIU8xp5CUQ
 nCC90Y3/HSVCkbQRwDFB4o7vuRRYIn9j8GM+Pf3BLPUEKpkcZ7SPG+tmw6VRysiBBH3+
 HXyA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=T1HaJuokhMjgl1Nju0e+RrNTBPvUpx6J33EHmxuUKU8=;
 b=hotjNrQel7rXyAegFMzOdC5sYQ/ZaehytJyYbdR1Rqy+c1E1UyeN0dro4XkAmLxi90
 ODTVH5OtPkOwk+YG8bsBUkaoWVS5F1Xhn08Wb8BPC8Skjae3GsFkEODq1JXzIlT6kkU/
 HViTxCrIKcT4XAE+jrqoa1fi5l5OFw4g7CHwzyeJu8Kx3D/xiQUcWgGJSE/i2r4fTrRb
 JUP9zK4BWEZonb2jh4BdOwyFHPP5hCI/HDJdOKzmcd0CA3roUwSezCFTXt/vvC2PuIrC
 wNL3bESCg7Uji+ipPRBw9lEg3DzkCh/ntihiW/uzHzO3oE0oqeMMUGK5n53DcItzuK5Y
 RNZg==
X-Gm-Message-State: AD7BkJIxQ1ErbZjQi/SZJEyUBUw95Gtv2JbSYZOozb69qr6esh1sHMX9auUMjOhoPo8Www==
X-Received: by 10.66.222.41 with SMTP id qj9mr14779693pac.136.1459356321192;
 Wed, 30 Mar 2016 09:45:21 -0700 (PDT)
Received: from xeon-e3 (static-50-53-73-178.bvtn.or.frontiernet.net.
 [50.53.73.178])
 by smtp.gmail.com with ESMTPSA id ey7sm7140356pab.47.2016.03.30.09.45.20
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 30 Mar 2016 09:45:21 -0700 (PDT)
Date: Wed, 30 Mar 2016 09:45:37 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: <bruce.richardson@intel.com>, <thomas.monjalon@6wind.com>,
 <dev@dpdk.org>, <ameen.rahman@qlogic.com>, <harish.patil@qlogic.com>,
 <sony.chacko@qlogic.com>
Message-ID: <20160330094537.024bed45@xeon-e3>
In-Reply-To: <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com>
References: <1459315705-25001-1-git-send-email-rasesh.mody@qlogic.com>
 <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 05/10] qede: Add core driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Mar 2016 16:45:22 -0000

On Tue, 29 Mar 2016 22:28:20 -0700
Rasesh Mody <rasesh.mody@qlogic.com> wrote:

> +static void
> +qede_alloc_etherdev(struct qede_dev *qdev, struct qed_dev_eth_info *info)
> +{
> +	rte_memcpy(&qdev->dev_info, info, sizeof(*info));

Why bother with rte_memcpy here? why not just assignment or memcpy()?

> +	qdev->num_tc = qdev->dev_info.num_tc;
> +	qdev->ops = qed_ops;
> +}