DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] scripts: check commit formatting
Date: Wed, 30 Mar 2016 15:46:31 +0100	[thread overview]
Message-ID: <20160330144631.GD21156@bricha3-MOBL3> (raw)
In-Reply-To: <20160330144414.GD3080@yliu-dev.sh.intel.com>

On Wed, Mar 30, 2016 at 10:44:14PM +0800, Yuanhan Liu wrote:
> On Wed, Mar 30, 2016 at 03:27:40PM +0100, Bruce Richardson wrote:
> > On Wed, Mar 30, 2016 at 09:46:34AM +0800, Yuanhan Liu wrote:
> > > On Tue, Mar 29, 2016 at 11:29:46PM +0200, Thomas Monjalon wrote:
> > > > The git messages have three parts:
> > > > 1/ the headline
> > > > 2/ the explanations
> > > > 3/ the footer tags
> > > > 
> > > > The headline helps to quickly browse an history or catch instantly the
> > > > purpose of a commit. Making it short with some consistent wording
> > > > allows to easily parse it or match some patterns.
> > > > 
> > > > The explanations must give some keys like the reason of the change.
> > > > Nothing can be automatically checked for this part.
> > > 
> > > Actually, I think we might be able to do 2 tests here:
> > > 
> > > - space line between paragraphs.
> > > 
> > > - lines over 80 chars.
> > 
> > 75 chars for commit messages, and 50 for commit titles :-)
> 
> I'd agree that 75 char is better. My personal preference is actually
> 68 :) 
> 
I just go with what vim uses on my machine, because vim is always right :-)

  reply	other threads:[~2016-03-30 14:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-29 21:29 Thomas Monjalon
2016-03-30  1:46 ` Yuanhan Liu
2016-03-30 14:27   ` Bruce Richardson
2016-03-30 14:44     ` Yuanhan Liu
2016-03-30 14:46       ` Bruce Richardson [this message]
2016-04-11 10:00     ` Thomas Monjalon
2016-04-11 15:39 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2016-04-11 16:13   ` Yuanhan Liu
2016-04-11 21:59     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160330144631.GD21156@bricha3-MOBL3 \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).