From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 9633F37A6 for ; Wed, 30 Mar 2016 23:48:17 +0200 (CEST) Received: by mail-pa0-f51.google.com with SMTP id td3so49731626pab.2 for ; Wed, 30 Mar 2016 14:48:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=liSMlix/efWWpQjPPsF0lf6vRQ+Z4s5ocWh9E9VpFBQ=; b=M9uS5UabXYcV3XKGTPLWJqckNaiTO6cOW+ZJsKHV/xCcZ36tMBsJRv54HUYHWFl+CN TPYVa6m5J9+CXHE8K+yOVnO++CnGd+RuS4S7aMky/SzNFog33tsDEpY6wwtZPwNVyVTG 2qpbFyQfORHvCxKEXWqirX8vCiFtzQZema/JV7oSEutE5KpUBHa4XA7+BTZ1VXs8LGcl TSdxMapggCn7ghJP+lwm3DjnQTTxM7hVo+QVtWwEkl74XlQwdu7WcvhTd5ojIRSNN/ku TrBv0ag8Cyn837OIwe8RDyf3r44LxmOvK9gpk7/BJj7burAq917/AJEMybdW9ImXMjEw RQ7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=liSMlix/efWWpQjPPsF0lf6vRQ+Z4s5ocWh9E9VpFBQ=; b=SR36ONBq19K39tted9SqItP6zduwWMSKkvVNaPlrxJ5d2IvkbEi2GAkuETWuEOfhxC AI9oLne6UI+gVf7J1BIIcp+aVXDeBkN8/k7Xnc7NS2aXeKvrOyYR74zZ0WFR3WFoU6f4 ZlYEgcm7QsZK06rTlFqKnXuaIW8+NT5Qu8RRUykg8bZ0DUyLh73/g/793Vp5n4eaaRfI RkJEO/u4wK/FHrnAetTXWiBv4Ro1sX9jrxpW7GZ6OkeL8dsJRYNwRxVOsq4FbOc+I/FY 5OCdF8mf7zmV0I0Zs6kdx4KeD5VtZwJQ59c+lPblAMHzWZD6Smsl9eaq9t5yoFu2ixc0 OwTQ== X-Gm-Message-State: AD7BkJIHvj9gsD0FEdRzGJhfZs0vQdT2kpN6uos7sbPo3ACS1zhWwUeCPjkgruXViS4MSA== X-Received: by 10.66.255.39 with SMTP id an7mr16813556pad.2.1459374497034; Wed, 30 Mar 2016 14:48:17 -0700 (PDT) Received: from xeon-e3 (static-50-53-73-178.bvtn.or.frontiernet.net. [50.53.73.178]) by smtp.gmail.com with ESMTPSA id lq10sm8128738pab.36.2016.03.30.14.48.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Mar 2016 14:48:16 -0700 (PDT) Date: Wed, 30 Mar 2016 14:48:32 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: Aaron Conole , Panu Matilainen , "Lu, Wenzhuo" , dev@dpdk.org, "Richardson, Bruce" Message-ID: <20160330144832.65ca1897@xeon-e3> In-Reply-To: <10236988.vM3noimEBN@xps13> References: <1458682638-28378-1-git-send-email-aconole@redhat.com> <20160330093653.0d7e1847@xeon-e3> <10236988.vM3noimEBN@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 2/7] drivers/net/e1000: Suppress misleading indentation warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2016 21:48:18 -0000 On Wed, 30 Mar 2016 19:12:39 +0200 Thomas Monjalon wrote: > 2016-03-30 09:36, Stephen Hemminger: > > On Wed, 30 Mar 2016 10:06:36 -0400 > > Aaron Conole wrote: > > > --- a/drivers/net/e1000/Makefile > > > +++ b/drivers/net/e1000/Makefile > > > @@ -54,6 +54,9 @@ else > > > # > > > CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter > > > CFLAGS_BASE_DRIVER += -Wno-unused-variable > > > +ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1) > > > +CFLAGS_BASE_DRIVER += -Wno-misleading-indentation > > > +endif > > > endif > > > > NAK, don't do it to the whole file. > > Fix the code (best option) > > or use a pragma for the small area which is broken for other reasons. > > Stephen, your solutions do not work because Aaron has not been allowed > to modify this file. > As long as we are not allowed to modify the Intel base drivers, > I don't see any problem to hide some warnings in them. > The warnings could help us to clean the code or fix some bugs but > we are not allowed to... > It is the responsibility of the driver maintainer to keep this nasty code. ok, but the policy of "base drivers are allowed to be unmaintainable" is an albatross around the neck of DPDK. There is a reason such a policy was rejected in Linux.