From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id 07855293C for ; Wed, 30 Mar 2016 23:50:27 +0200 (CEST) Received: by mail-pf0-f178.google.com with SMTP id x3so52551809pfb.1 for ; Wed, 30 Mar 2016 14:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CWGS07TeZbo2GZeArLSHZBcHj48183jbZbkDwbi1qB0=; b=g23fY+U8uugEADmWNB5LjcWJMLjXCAIioIglCXGMBSOTAX4eo4Fwu61Q2JLXeYaU/E ty9AoF31UFyTwEHlzTx5JbEy/YbzXxvrmDMfs5wu0rh0ToeaZdyf4VP4le66Fxi4DYtn 1TkOmBvp5TbvKuC5paK6AOtZZNPZREea6q+xNBM48G2BOhAQZibBKtlsN6BzGPPTtooH Pg2VVjPh6SsLODZGP+gD4OenKP+GluAA2O1tDCs+kSNthys/kn1RvJTODHqBO6a28JKj KJNos4FDD8fIF0zhkEDASIWdexksBz9e6dbQKHvh08hZv30Wt8/a88KLmC7arEkIrcxD xdAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CWGS07TeZbo2GZeArLSHZBcHj48183jbZbkDwbi1qB0=; b=SUpadXyNam4Kuzku8ZdhdiqtvMZtlfYEFmSbYKjciOM1MDSjXeFOR2rpUrFYOAQlQb kv1rcVum7zxGmAZtSewfeZhUm6OR0LeJHkRCKdJiX/luq9sejNkXhBIul5jhWXK0W1AG 6Q32/ZaAMgGJR6L0j1lo1gEDN6LN1MC8KeEO4QSyYBd5EgSzVdBxfxMZM4CVv02ZSAsw t1Q/GodpIASF6Tr2PTdeJqc6a2NwTGmQaQNXJ0mFpuE+Qyaf7ZeiywRDASzSxeBBx6ym TUn8xEot0WmBUtQn5sp6qZb6pAy+Lr0vGFJZVVzCxN+5WJf55qARI7yA22j5KFNo+IxT p3Vw== X-Gm-Message-State: AD7BkJLx3yJ/hqpBxbkMShS7AF1chahLicCl7qUt4/X/crzXrBtIOUMaGtPnOOKfWaHMTw== X-Received: by 10.98.87.200 with SMTP id i69mr16589207pfj.63.1459374626452; Wed, 30 Mar 2016 14:50:26 -0700 (PDT) Received: from xeon-e3 (static-50-53-73-178.bvtn.or.frontiernet.net. [50.53.73.178]) by smtp.gmail.com with ESMTPSA id ql1sm8151779pac.24.2016.03.30.14.50.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Mar 2016 14:50:26 -0700 (PDT) Date: Wed, 30 Mar 2016 14:50:42 -0700 From: Stephen Hemminger To: Lee Roberts Cc: dev@dpdk.org Message-ID: <20160330145042.1708ecee@xeon-e3> In-Reply-To: <1459361615-6021-1-git-send-email-lee.roberts@hpe.com> References: <1459361615-6021-1-git-send-email-lee.roberts@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] Fix KNI compilation under Wind River Linux 6.0 recent RCPLs. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2016 21:50:27 -0000 On Wed, 30 Mar 2016 12:13:35 -0600 Lee Roberts wrote: > skb_set_hash() has been backported to recent Wind River Linux 6.0 RCPLs. > As a result, the corresponding stanza in kcompat.h must be removed. > Similar patches have already been applied for RHEL, SLES and Ubuntu. > > Wind River Linux does not provide convenient macros for kernel version > identification. Add macros to Makefile to identify the Wind River Linux > version. > > Signed-off-by: Lee Roberts > --- > lib/librte_eal/linuxapp/kni/Makefile | 8 ++++++++ > lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 13 +++++++++++++ > 2 files changed, 21 insertions(+) > > diff --git a/lib/librte_eal/linuxapp/kni/Makefile b/lib/librte_eal/linuxapp/kni/Makefile > index ac99d3f..6310615 100644 > --- a/lib/librte_eal/linuxapp/kni/Makefile > +++ b/lib/librte_eal/linuxapp/kni/Makefile > @@ -51,6 +51,14 @@ UBUNTU_KERNEL_CODE := $(shell echo `grep UTS_RELEASE $(RTE_KERNELDIR)/include/ge > MODULE_CFLAGS += -D"UBUNTU_KERNEL_CODE=UBUNTU_KERNEL_VERSION($(UBUNTU_KERNEL_CODE))" > endif > > +ifeq ($(shell lsb_release -si 2>/dev/null),wrlinux) > +WRLINUX_MAJOR := $(shell lsb_release -sr | cut -d. -f1) > +WRLINUX_MINOR := $(shell lsb_release -sr | cut -d. -f2) > +WRLINUX_RCPL := $(shell lsb_release -sr | cut -d. -f4) > +MODULE_CFLAGS += -D"WRLINUX_RELEASE_CODE=WRLINUX_RELEASE_VERSION($(WRLINUX_MAJOR),$(WRLINUX_MINOR))" > +MODULE_CFLAGS += -D"WRLINUX_RCPL=$(WRLINUX_RCPL)" > +endif > + Do we want to require DPDK to work in the face of every weird vendor kernel backport. This is a road to nowhere... One more reason to get kernel drivers upstream.