From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 186292C3F for ; Thu, 31 Mar 2016 01:55:51 +0200 (CEST) Received: by mail-pa0-f51.google.com with SMTP id fe3so52168027pab.1 for ; Wed, 30 Mar 2016 16:55:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7tE6uT16MX0lScavWht1uQsOvZtlShxqygqBExju9rw=; b=T3CNgt9bCIxwxLNO1gTz54LVhUEALsjVThzDtGK8n42cHtDL6Y2usEhx+1EIpsWGbF DvzF6B5mioLBZCbSVK3NY/d1iIKr3UVGlqKHAzud0va+cz1CxaKh72JweXlXygMajUpr aaf31ChDbJOKp2LOYCSaFhqfM2xWPrAa8iD6XNfhZ3haTMcnrfK9mmBUPP5xLQrLzz4X rSPNRGgA/CzRHA9EGi8RPSAWixo/6irLQyrnbbtbviwxsHhmdNSYk1cbYuvD5YGDhnIN GBKOcADDX9bwFwBYnzqAmLU6mSuNn7FP0bPuNiHEtAiIN8Gdae+1nQBzDDlc+WMUDt6+ TXgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7tE6uT16MX0lScavWht1uQsOvZtlShxqygqBExju9rw=; b=PGroz2hDfWFaA/rmZYNunR1HH7CXhfO5iVfbolH1afjME99EkojJ//mybg9Yc9yh4f rpQmQG9sIb0F40mbzcHXEWm7XTBRwuPGEDOkgQsx9NXh+RzAfA4IcluRmfCiu09IuhMZ /+coRaleSHcVi5pODutoJYqIG/ddjdxaHeEvRXB6cz1mppJE/6xvEmscVgfBwH5SK3ul 8E5esSZUmren5OpPAHNX30DS9N/wQBl6AR84Ebg6s3x2Jd77W4B/ASWOhu5Pvz8j8WnC 9wK3NHyyVW8pk+rFE19vaOwR3yP7CetTSOtny7MbDUaICiMHYzSipMiZkpT/1RN4gg14 mIQg== X-Gm-Message-State: AD7BkJI8shC+qLLouh8NlkgUL+BmcP8o61pLK9eDNBZ0mpLvrA7MTdumrjGa3Eb4a8N+Cw== X-Received: by 10.66.90.226 with SMTP id bz2mr17550857pab.31.1459382150441; Wed, 30 Mar 2016 16:55:50 -0700 (PDT) Received: from xeon-e3 (static-50-53-73-178.bvtn.or.frontiernet.net. [50.53.73.178]) by smtp.gmail.com with ESMTPSA id 3sm8437184pfn.59.2016.03.30.16.55.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Mar 2016 16:55:50 -0700 (PDT) Date: Wed, 30 Mar 2016 15:37:43 -0700 From: Stephen Hemminger To: Harish Patil Cc: "bruce.richardson@intel.com" , "thomas.monjalon@6wind.com" , "dev@dpdk.org" , Rasesh Mody Message-ID: <20160330153743.63605112@xeon-e3> In-Reply-To: References: <1459315705-25001-1-git-send-email-rasesh.mody@qlogic.com> <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com> <20160330093926.6bff277c@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 05/10] qede: Add core driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2016 23:55:51 -0000 On Wed, 30 Mar 2016 22:16:51 +0000 Harish Patil wrote: > > > >On Tue, 29 Mar 2016 22:28:20 -0700 > >Rasesh Mody wrote: > > > >> + > >> +static void qede_print_adapter_info(struct qede_dev *qdev) > >> +{ > >> + struct ecore_dev *edev = &qdev->edev; > >> + struct qed_dev_info *info = &qdev->dev_info.common; > >> + char ver_str[QED_DRV_VER_STR_SIZE] = { 0 }; > >> + > >> + RTE_LOG(INFO, PMD, > >> + " Chip details : %s%d\n", > >> + ECORE_IS_BB(edev) ? "BB" : "AH", > >> + CHIP_REV_IS_A0(edev) ? 0 : 1); > >> + > >> + sprintf(ver_str, "%s %s_%d.%d.%d.%d", QEDE_PMD_VER_PREFIX, > >> + edev->ver_str, QEDE_PMD_VERSION_MAJOR, QEDE_PMD_VERSION_MINOR, > >> + QEDE_PMD_VERSION_REVISION, QEDE_PMD_VERSION_PATCH); > >> + strcpy(qdev->drv_ver, ver_str); > >> + RTE_LOG(INFO, PMD, " Driver version : %s\n", ver_str); > >> + > >> + ver_str[0] = '\0'; > >> + sprintf(ver_str, "%d.%d.%d.%d", info->fw_major, info->fw_minor, > >> + info->fw_rev, info->fw_eng); > >> + RTE_LOG(INFO, PMD, " Firmware version : %s\n", ver_str); > >> + > >> + ver_str[0] = '\0'; > >> + sprintf(ver_str, "%d.%d.%d.%d", > >> + (info->mfw_rev >> 24) & 0xff, > >> + (info->mfw_rev >> 16) & 0xff, > >> + (info->mfw_rev >> 8) & 0xff, (info->mfw_rev) & 0xff); > >> + RTE_LOG(INFO, PMD, " Management firmware version : %s\n", ver_str); > >> + > >> + RTE_LOG(INFO, PMD, " Firmware file : %s\n", QEDE_FW_FILE_NAME); > > > >This means the driver is far too chatty in the logs. > >Can't this be made DEBUG level? > > > Not clear what is the issue here? > RTE_LOG is used here to display basic adapter info like firmware/driver > versions etc without the need to enable any debug flags. > The driver debug logging is under the control of appropriate debug flags. > The DPDK log messages end up being examined by tech support and customers. Too much code puts extra stuff in so it is hard to find the real problem. This is obviously debug info, so either: 1) make it conditionally compiled 2) change log level to DEBUG 3) remove it.