From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zhe.tao@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 7CCD269F8
 for <dev@dpdk.org>; Thu, 31 Mar 2016 14:13:37 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga102.jf.intel.com with ESMTP; 31 Mar 2016 05:13:37 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,422,1455004800"; d="scan'208";a="678555901"
Received: from adambynes.sh.intel.com (HELO adambynes) ([10.239.129.240])
 by FMSMGA003.fm.intel.com with ESMTP; 31 Mar 2016 05:13:35 -0700
Date: Thu, 31 Mar 2016 11:58:40 +0800
From: Zhe Tao <zhe.tao@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, jingjing.wu@intel.com
Message-ID: <20160331035840.GA67384@intel.com>
References: <1458652425-6167-1-git-send-email-zhe.tao@intel.com>
 <1458703670-19898-1-git-send-email-zhe.tao@intel.com>
 <20160324150013.GG13728@bricha3-MOBL3>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160324150013.GG13728@bricha3-MOBL3>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v2] i40e: fix ipv6 TSO issue for tx function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Mar 2016 12:13:37 -0000

On Thu, Mar 24, 2016 at 03:00:14PM +0000, Bruce Richardson wrote:
> On Wed, Mar 23, 2016 at 11:27:50AM +0800, Zhe Tao wrote:
> > Issue:
> > when using the following CLI in testpmd to enable ipv6 TSO feature
> > =============
> > set verbose 1
> > csum set ip hw 0
> > csum set udp hw 0
> > csum set tcp hw 0
> > csum set sctp hw 0
> > csum set outer-ip hw 0
> > csum parse_tunnel on 0
> > tso set 800 0
> > set fwd csum
> > 
> > start
> > =============
> 
> The "===" lines in the message are confusing patchwork. For a new version of
> this patch can you indent the commands rather than putting the "===" above and 
> below. E.g.
> 
>  Issue:
>  when using the following CLI in testpmd to enable ipv6 TSO feature
> 
>  	set verbose 1
>  	csum set ip hw 0
>  	csum set udp hw 0
> 	....
> 
> Thanks,
> /Bruce
very good advise, will send the new patch, thanks!
Zhe Tao