Re: [dpdk-dev] [PATCH v3 0/8] L2fwd-crypto fixes/enhancements

[Bruce Richardson <bruce.richardson@intel.com>]

On Thu, Mar 31, 2016 at 10:32:06AM +0100, Pablo de Lara wrote:
> This patches fixes some small issues in L2fwd-crypto
> app and also improves the app, making it more flexible
> (accepting different key sizes)
> and readable (information display improvement).
> 
> Series-tested-by: Min Cao <min.cao@intel.com>
> 

Hi,

Just some general advice:

When someone is acking/resporting a tested-by for a patch series it's ok to 
reply to the patch 0.

However, for subsequent versions of the patchset itself, the acks and tested-bys
should be placed on (all) the patches themselves, not in the cover letter. If
it's in the cover letter, you're forcing the applier of the patch to modify each
one individually to stick on the extra information.

Thanks,
/Bruce

> 
> Changes in v3:
> 
> - Added missing Tested-by line.
> 
> Changes in v2:
> 
> - Extended help information
> 
> Pablo de Lara (8):
>   l2fwd-crypto: add missing new line character in help
>   l2fwd-crypto: rename period parameter
>   l2fwd-crypto: add missing string initialization
>   l2fwd-crypto: fix length of random IV/AAD
>   l2fwd-crypto: fix ambiguous input key size
>   l2fwd-crypto: clarify key parsing in help
>   l2fwd-crypto: use key-value list of supported algorithms
>   l2fwd-crypto: extend crypto information
> 
>  examples/l2fwd-crypto/main.c          | 473 ++++++++++++++++++++++++++++------
>  lib/librte_cryptodev/rte_crypto_sym.h |   6 +-
>  2 files changed, 402 insertions(+), 77 deletions(-)
> 
> -- 
> 2.5.5
>