From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com
 [209.85.220.46]) by dpdk.org (Postfix) with ESMTP id DD8CF2965
 for <dev@dpdk.org>; Fri,  1 Apr 2016 17:41:28 +0200 (CEST)
Received: by mail-pa0-f46.google.com with SMTP id fe3so93646852pab.1
 for <dev@dpdk.org>; Fri, 01 Apr 2016 08:41:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=zBudyFf7ZPCwAhzpuMOWiMUunWQDVqrHaDCgxaLbFCc=;
 b=PohWJ7SwZvqrs5xFogrJaDcydgl8rQvD8tcuAn33PYqvGgjMyrviHAQsZhzk9c8Vfl
 s36wOmtMnTx+0TpDqYTULotddb+eaCgKMiofHok4jPxfFI5A7XSxgCLt7I8zYoguZjwz
 NviWDh2w2sQ1wbXh/dB2gHpQn61ihDA+8rC6TDTL/Tyltgv0+jZSya1tjt75dA0uf9gq
 y4sbGuaNePcLvoQWMYjh+SxNYEqRaE43zmAaK5O/xe/Q7tRPO81rK2XnqHqy9JPyJs3j
 TLmsEt43AdbeDbTmsdCgOCEWWW9ZHWMOxah0jL/YLNIiQSrLfbn4F2ilH1qLhi0XawBf
 6sDw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=zBudyFf7ZPCwAhzpuMOWiMUunWQDVqrHaDCgxaLbFCc=;
 b=R7xBTcNvstJc9c8WmK3U7noD7ZgKZ00RkAh/pkiD3kJ1Y4pQPZ/vY/mtDSWknlaGoz
 xrrCXutcGGXsYn8Dft++qJXMa5efM0aD661ADC/Ta262h0BUyXrMZEYM3SYnJBBjpomT
 TJGqYyB9oTseKTAV+YDQteHEeEMhU6D+SlhKwg6DFIZ0WmlQk4O/cwLMpmX3mvtnNlg0
 jaf0UW0bfosq6lpwrnNJBoq1QhJhw2KJTppB1svaDy7KzrBjMrNG00XoXTLb/2BL4roJ
 AP/m6/0E50mNegNdACUn54lXcsYDwc+VC29fBcvXvY6EUT7pY9vnjpJqXEtdTcm8cSgX
 udDg==
X-Gm-Message-State: AD7BkJKjsB044NuZo5bk9YC4cF5LN0j197RWyFt0ZqIYhByKwTN+jcLMQ41TWyVfKoTpsA==
X-Received: by 10.66.222.202 with SMTP id qo10mr370115pac.141.1459525287949;
 Fri, 01 Apr 2016 08:41:27 -0700 (PDT)
Received: from xeon-e3 (static-50-53-73-178.bvtn.or.frontiernet.net.
 [50.53.73.178])
 by smtp.gmail.com with ESMTPSA id yj1sm22427796pac.16.2016.04.01.08.41.27
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 01 Apr 2016 08:41:27 -0700 (PDT)
Date: Fri, 1 Apr 2016 08:41:42 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: <thomas.monjalon@6wind.com>, <bruce.richardson@intel.com>,
 <dev@dpdk.org>, <ameen.rahman@qlogic.com>, <harish.patil@qlogic.com>,
 <sony.chacko@qlogic.com>
Message-ID: <20160401084142.11bd9a06@xeon-e3>
In-Reply-To: <1459476927-21387-6-git-send-email-rasesh.mody@qlogic.com>
References: <1459476927-21387-1-git-send-email-rasesh.mody@qlogic.com>
 <1459476927-21387-6-git-send-email-rasesh.mody@qlogic.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v5 05/10] qede: Add core driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Apr 2016 15:41:29 -0000

On Thu, 31 Mar 2016 19:15:22 -0700
Rasesh Mody <rasesh.mody@qlogic.com> wrote:

> +struct qed_filter_ucast_params {
> +	enum qed_filter_xcast_params_type type;
> +	uint8_t vlan_valid;
> +	uint16_t vlan;
> +	uint8_t mac_valid;
> +	unsigned char mac[ETHER_ADDR_LEN];
> +} __attribute__ ((__packed__));

Why packed? Why not just rearrange elements to eliminate the padding holes?