From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com
 [209.85.220.50]) by dpdk.org (Postfix) with ESMTP id 4276C2965
 for <dev@dpdk.org>; Fri,  1 Apr 2016 17:42:19 +0200 (CEST)
Received: by mail-pa0-f50.google.com with SMTP id tt10so93558785pab.3
 for <dev@dpdk.org>; Fri, 01 Apr 2016 08:42:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=RMbJKObLdIrDctZaTMeEQsSP8SmL2wnqwGfIpDLJrRU=;
 b=GAbLjqs1sU7j0EIFpDK1RdHOs2SVzOzjluOdOjvO7mHa/9AFKTFleG4sBXQpmpdyp5
 7NJDFAdTkIelSIGH1jmLeh2wlBdFhfwPE1pa20Xe66EW49+CMm466KSnsR8F8vtaG6h2
 Q8QQ0/q5Cq7qNK9Aw9nmcpwunO5BiBUGlTtviS87gwEYX2l/ZlD6KgN7njyLGNFbMLlU
 HmoT4llpMAcjIqxFltBPCWcYDGjWP2jHguFCryO0BRTYEZypFd8two1id2W61mvZU8Iw
 Pj8o6FcxkfzjfwBAJpZIIubRqhKzawrui0bU1O4nYmjER9QHdd5mVeeS12sHg3cQ/7O2
 hkYw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=RMbJKObLdIrDctZaTMeEQsSP8SmL2wnqwGfIpDLJrRU=;
 b=gXYEv69B4xH/3Q4qt3IeHYre6Q5Q057s2qnjcapMRDacrrTiA2M/GwEUuXW9gqol8T
 QTL1D4DVOfPMW4h18Jt0AcZC7QEz7FtDwoP0/WDyPyiyUPWVl3Vpc1IyikEXdpOYePMO
 +PtiGxMy3+mSybMJ6toHni0v6Upy1UakZZKBbi2Dt/eSNczypNx95LX+nm9leY1e17Cr
 1jc4faJnnHTF10HERfTpXT/rDKCs47i6s6C272Lth6dSEX8bJYav3VK0hYL98OA1yzgS
 bk3Z9CV/RBQNrxDHPTVqymT0byqwNQGHige3M0m230Mp0Ieu/9HJxd42lm5bZ0rMMP0e
 G9Bg==
X-Gm-Message-State: AD7BkJJD+65CCzGgSytuLcLQrd2XClJTmF20uz43aYfUspSLwDgXA6e62o0Qx1eiNshO6Q==
X-Received: by 10.66.175.110 with SMTP id bz14mr31968263pac.41.1459525338601; 
 Fri, 01 Apr 2016 08:42:18 -0700 (PDT)
Received: from xeon-e3 (static-50-53-73-178.bvtn.or.frontiernet.net.
 [50.53.73.178])
 by smtp.gmail.com with ESMTPSA id kl14sm22452221pab.23.2016.04.01.08.42.17
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 01 Apr 2016 08:42:18 -0700 (PDT)
Date: Fri, 1 Apr 2016 08:42:33 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: <thomas.monjalon@6wind.com>, <bruce.richardson@intel.com>,
 <dev@dpdk.org>, <ameen.rahman@qlogic.com>, <harish.patil@qlogic.com>,
 <sony.chacko@qlogic.com>
Message-ID: <20160401084233.2056c7c3@xeon-e3>
In-Reply-To: <1459476927-21387-6-git-send-email-rasesh.mody@qlogic.com>
References: <1459476927-21387-1-git-send-email-rasesh.mody@qlogic.com>
 <1459476927-21387-6-git-send-email-rasesh.mody@qlogic.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v5 05/10] qede: Add core driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Apr 2016 15:42:19 -0000

On Thu, 31 Mar 2016 19:15:22 -0700
Rasesh Mody <rasesh.mody@qlogic.com> wrote:

> +struct qed_filter_mcast_params {
> +	enum qed_filter_xcast_params_type type;
> +	uint8_t num;
> +	unsigned char mac[64][ETHER_ADDR_LEN];
> +};

Would prefer a #define constant for the maximum number of multicast
addresses rather than magic number of 64.