From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id A6CDB2BFD
 for <dev@dpdk.org>; Tue,  5 Apr 2016 06:25:29 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga103.jf.intel.com with ESMTP; 04 Apr 2016 21:25:28 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,442,1455004800"; d="scan'208";a="79136421"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.191])
 by fmsmga004.fm.intel.com with ESMTP; 04 Apr 2016 21:25:27 -0700
Date: Tue, 5 Apr 2016 12:26:54 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Cc: Rich Lane <rich.lane@bigswitch.com>, dev@dpdk.org,
 Huawei Xie <huawei.xie@intel.com>,
 Stephen Hemminger <stephen@networkplumber.org>
Message-ID: <20160405042654.GN3080@yliu-dev.sh.intel.com>
References: <1459822261-95284-1-git-send-email-rlane@bigswitch.com>
 <57032EE5.4050408@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <57032EE5.4050408@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v2] virtio: use zeroed memory for simple TX
 header
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Apr 2016 04:25:30 -0000

On Tue, Apr 05, 2016 at 11:20:05AM +0800, Tan, Jianfeng wrote:
> Hi,
> 
> On 4/5/2016 10:11 AM, Rich Lane wrote:
> >For simple TX the virtio-net header must be zeroed, but it was using memory
> >that had been initialized with indirect descriptor tables. This resulted in
> >"unsupported gso type" errors from librte_vhost.
> >
> >We can use the same memory for every descriptor to save cachelines in the
> >vswitch.
> 
> Pointing all virtio_net_hdr into the same memory may brings performance, but
> how much? It also introduces difficulty to adding tso in future?

simple rxtx will not be enabled when TSO is enabled.

	--yliu