From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <viktorin@rehivetech.com>
Received: from wes1-so1.wedos.net (wes1-so1.wedos.net [46.28.106.15])
 by dpdk.org (Postfix) with ESMTP id 5542A2C38
 for <dev@dpdk.org>; Tue,  5 Apr 2016 22:22:44 +0200 (CEST)
Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz
 [147.229.13.147])
 by wes1-so1.wedos.net (Postfix) with ESMTPSA id 3qfgJh01vFz4xp;
 Tue,  5 Apr 2016 22:22:43 +0200 (CEST)
Date: Tue, 5 Apr 2016 22:23:04 +0200
From: Jan Viktorin <viktorin@rehivetech.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>, Thomas
 Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20160405222304.20a38b6d@pcviktorin.fit.vutbr.cz>
In-Reply-To: <1459865290-10248-8-git-send-email-adrien.mazarguil@6wind.com>
References: <1459865290-10248-8-git-send-email-adrien.mazarguil@6wind.com>
Organization: RehiveTech
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [dpdk-dev,
	07/10] lib: fix missing include dependencies
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Apr 2016 20:22:44 -0000

Hello Adrien,

just quickly skimming through the ARM fixes...

On Tue,  5 Apr 2016 16:08:07 +0200
Adrien Mazarguil <adrien.mazarguil@6wind.com> wrote:

> Exported header files for use by applications should be self sufficient and
> allow out of order inclusion. Moreover, they must include all the system
> headers they need for types and macros.
> 
> This commit prevents the following errors:
> 
>  error: `RTE_MAX_LCORE' undeclared here (not in a function)
>  error: `RTE_LPM_VALID_EXT_ENTRY_BITMASK' undeclared (first use in this function)
>  error: #error "Unsupported cache line size"
>  error: `asm' undeclared (first use in this function)
>  error: implicit declaration of function `[...]'
>  error: unknown type name `[...]'
>  error: field `mac_addr' has incomplete type
>  error: `CHAR_BIT' undeclared here (not in a function)
>  error: `struct timespec' declared inside parameter list
> 
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> 
> ---
[...]
> +
>  #ifdef __cplusplus
>  extern "C" {
>  #endif
> diff --git a/lib/librte_eal/common/include/arch/arm/rte_byteorder.h b/lib/librte_eal/common/include/arch/arm/rte_byteorder.h
> index 3f2dd1f..c2078e7 100644
> --- a/lib/librte_eal/common/include/arch/arm/rte_byteorder.h
> +++ b/lib/librte_eal/common/include/arch/arm/rte_byteorder.h
> @@ -37,6 +37,9 @@
>  #  error Platform must be built with CONFIG_RTE_FORCE_INTRINSICS
>  #endif
>  
> +#include <stdint.h>
> +#include <rte_common.h>

Why not to place it into the extern "C" { block? There is already:

#include "generic/rte_byteorder.h"

> +
>  #ifdef __cplusplus
>  extern "C" {
>  #endif
> diff --git a/lib/librte_eal/common/include/arch/arm/rte_prefetch_32.h b/lib/librte_eal/common/include/arch/arm/rte_prefetch_32.h
> index 5aeed22..29b831b 100644
> --- a/lib/librte_eal/common/include/arch/arm/rte_prefetch_32.h
> +++ b/lib/librte_eal/common/include/arch/arm/rte_prefetch_32.h
> @@ -33,6 +33,8 @@
>  #ifndef _RTE_PREFETCH_ARM32_H_
>  #define _RTE_PREFETCH_ARM32_H_
>  
> +#include <rte_common.h>

I don't see any reason for this. The header does not use anything
special. Just "asm", but that should be a keyword...

> +
>  #ifdef __cplusplus
>  extern "C" {
>  #endif
> diff --git a/lib/librte_eal/common/include/arch/arm/rte_prefetch_64.h b/lib/librte_eal/common/include/arch/arm/rte_prefetch_64.h
> index 3ed46a4..600c6f0 100644
> --- a/lib/librte_eal/common/include/arch/arm/rte_prefetch_64.h
> +++ b/lib/librte_eal/common/include/arch/arm/rte_prefetch_64.h
> @@ -33,6 +33,8 @@
>  #ifndef _RTE_PREFETCH_ARM_64_H_
>  #define _RTE_PREFETCH_ARM_64_H_
>  
> +#include <rte_common.h>

Same here.

> +
>  #ifdef __cplusplus
>  extern "C" {
>  #endif
> diff --git a/lib/librte_eal/common/include/arch/arm/rte_vect.h b/lib/librte_eal/common/include/arch/arm/rte_vect.h
> index a33c054..b86c2cf 100644
> --- a/lib/librte_eal/common/include/arch/arm/rte_vect.h
> +++ b/lib/librte_eal/common/include/arch/arm/rte_vect.h
> @@ -33,6 +33,7 @@
>  #ifndef _RTE_VECT_ARM_H_
>  #define _RTE_VECT_ARM_H_
>  
> +#include <stdint.h>
>  #include "arm_neon.h"
>  
>  #ifdef __cplusplus
[...]

Regards
Jan