From: Bruce Richardson <bruce.richardson@intel.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: thomas.monjalon@6wind.com, dev@dpdk.org, ameen.rahman@qlogic.com,
harish.patil@qlogic.com
Subject: Re: [dpdk-dev] [PATCH v3 1/4] bnx2x: Update documentation
Date: Wed, 6 Apr 2016 15:32:36 +0100 [thread overview]
Message-ID: <20160406143235.GA6524@bricha3-MOBL3> (raw)
In-Reply-To: <1459903028-3329-1-git-send-email-rasesh.mody@qlogic.com>
On Tue, Apr 05, 2016 at 05:37:05PM -0700, Rasesh Mody wrote:
> Signed-off-by: Harish Patil <harish.patil@qlogic.com>
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> ---
> doc/guides/nics/bnx2x.rst | 1 +
> doc/guides/nics/overview.rst | 22 +++++++++++-----------
> 2 files changed, 12 insertions(+), 11 deletions(-)
>
Thanks for the patchset. Looking at it though, some of the changes are bug or
documentation fixes which would be good to get into 16.04 e.g. patch 1, and the
fix for the regular stats in patch 2, while other parts of the set, e.g. the TX
optimisations, or the new xstats functionality, are larger changes. Given we
are within days of a final release, the latter changes not really suitable for
merging at this point.
As per Thomas' guidance, the only code changes are meant to be bug fixes,
in case a change introduces a last minute issue.
Any chance you could split this patchset in two, with the doc and bug fixes alone
in one set, and the feature changes in a separate set for 16.07?
Thanks,
/Bruce
next prev parent reply other threads:[~2016-04-06 14:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 0:37 Rasesh Mody
2016-04-06 0:37 ` [dpdk-dev] [PATCH v3 2/4] bnx2x: Fix Tx Performance Rasesh Mody
2016-04-06 0:37 ` [dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get Rasesh Mody
2016-04-06 14:32 ` Van Haaren, Harry
2016-04-07 5:10 ` Rasesh Mody
2016-05-04 5:41 ` Rasesh Mody
2016-04-06 0:37 ` [dpdk-dev] [PATCH v3 4/4] bnx2x: Update PMD version to 1.0.1.1 Rasesh Mody
2016-04-06 14:32 ` Bruce Richardson [this message]
2016-04-07 5:08 ` [dpdk-dev] [PATCH v3 1/4] bnx2x: Update documentation Rasesh Mody
2016-04-07 18:22 ` [dpdk-dev] [PATCH] " Rasesh Mody
2016-04-07 21:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160406143235.GA6524@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=ameen.rahman@qlogic.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
--cc=rasesh.mody@qlogic.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).