From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E6CDA2C06 for ; Wed, 6 Apr 2016 16:34:12 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 06 Apr 2016 07:32:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,447,1455004800"; d="scan'208";a="779290506" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.135]) by orsmga003.jf.intel.com with SMTP; 06 Apr 2016 07:32:37 -0700 Received: by (sSMTP sendmail emulation); Wed, 06 Apr 2016 15:32:36 +0025 Date: Wed, 6 Apr 2016 15:32:36 +0100 From: Bruce Richardson To: Rasesh Mody Cc: thomas.monjalon@6wind.com, dev@dpdk.org, ameen.rahman@qlogic.com, harish.patil@qlogic.com Message-ID: <20160406143235.GA6524@bricha3-MOBL3> References: <1459903028-3329-1-git-send-email-rasesh.mody@qlogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459903028-3329-1-git-send-email-rasesh.mody@qlogic.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 1/4] bnx2x: Update documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2016 14:34:13 -0000 On Tue, Apr 05, 2016 at 05:37:05PM -0700, Rasesh Mody wrote: > Signed-off-by: Harish Patil > Signed-off-by: Rasesh Mody > --- > doc/guides/nics/bnx2x.rst | 1 + > doc/guides/nics/overview.rst | 22 +++++++++++----------- > 2 files changed, 12 insertions(+), 11 deletions(-) > Thanks for the patchset. Looking at it though, some of the changes are bug or documentation fixes which would be good to get into 16.04 e.g. patch 1, and the fix for the regular stats in patch 2, while other parts of the set, e.g. the TX optimisations, or the new xstats functionality, are larger changes. Given we are within days of a final release, the latter changes not really suitable for merging at this point. As per Thomas' guidance, the only code changes are meant to be bug fixes, in case a change introduces a last minute issue. Any chance you could split this patchset in two, with the doc and bug fixes alone in one set, and the feature changes in a separate set for 16.07? Thanks, /Bruce