DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: dev <dev@dpdk.org>, Daniele Di Proietto <diproiettod@vmware.com>
Subject: Re: [dpdk-dev] Memory leak when adding/removing vhost_user ports
Date: Mon, 18 Apr 2016 10:46:50 -0700	[thread overview]
Message-ID: <20160418174650.GD2576@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <CAATJJ0JLd9iqNBvD=kyfpzk5DjGF_pGz+hBNeionZpuctNBymQ@mail.gmail.com>

On Mon, Apr 18, 2016 at 07:18:05PM +0200, Christian Ehrhardt wrote:
> I assume there is a leak somewhere on adding/removing vhost_user ports.
> Although it could also be "only" a fragmentation issue.
> 
> Reproduction is easy:
> I set up a pair of nicely working OVS-DPDK connected KVM Guests.
> Then in a loop I
>    - add up to more 512 ports
>    - test connectivity between the two guests
>    - remove up to 512 ports
> 
> Depending on memory and the amount of multiqueue/rxq I use it seems to
> slightly change when exactly it breaks. But for my default setup of 4
> queues and 5G Hugepages initialized by DPDK it always breaks at the sixth
> iteration.
> Here a link to the stack trace indicating a memory shortage (TBC):
> https://launchpadlibrarian.net/253916410/apport-retrace.log
> 
> Known Todos:
> - I want to track it down more, and will try to come up with a non
> openvswitch based looping testcase that might show it as well to simplify
> debugging.
> - in use were Openvswitch-dpdk 2.5 and DPDK 2.2; Retest with DPDK 16.04 and
> Openvswitch master is planned.
> 
> I will go on debugging this and let you know, but I wanted to give a heads
> up to everyone.

Thanks for the report.

> In case this is a known issue for some of you please let me know.

Yeah, it might be. I'm wondering that virtio_net struct is not freed.
It will be freed only (if I'm not mistaken) when guest quits, by far.

BTW, could you dump the ovs-dpdk log?

	--yliu

  reply	other threads:[~2016-04-18 17:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-18 17:18 Christian Ehrhardt
2016-04-18 17:46 ` Yuanhan Liu [this message]
2016-04-18 18:14   ` Yuanhan Liu
2016-04-19 16:33     ` Christian Ehrhardt
2016-04-20  5:04       ` Yuanhan Liu
2016-04-20  6:18         ` Christian Ehrhardt
2016-04-21  5:54           ` Yuanhan Liu
2016-04-21  9:07             ` Christian Ehrhardt
2016-07-06 12:24       ` [dpdk-dev] [PATCH v2] " Christian Ehrhardt
2016-07-06 12:24         ` [dpdk-dev] [PATCH v2] vhost_user: avoid crash when exeeding file descriptors Christian Ehrhardt
2016-07-12  8:37           ` Yuanhan Liu
2016-07-15 19:46             ` Thomas Monjalon
2016-07-06 12:26         ` [dpdk-dev] [PATCH v2] Memory leak when adding/removing vhost_user ports Christian Ehrhardt
2016-07-06 12:30           ` Christian Ehrhardt
2016-07-06 12:37             ` Christian Ehrhardt
2016-07-06 13:08         ` Yuanhan Liu
2016-07-12 12:08           ` Yuanhan Liu
2016-07-19 13:50             ` Christian Ehrhardt
2016-04-21 11:01 ` [dpdk-dev] " Ilya Maximets
2016-04-21 14:04   ` Christian Ehrhardt
2016-04-21 16:56     ` Yuanhan Liu
2016-04-21 16:54   ` Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160418174650.GD2576@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=dev@dpdk.org \
    --cc=diproiettod@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).