From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Harish Patil <harish.patil@qlogic.com>,
Rasesh Mody <rasesh.mody@qlogic.com>,
dev@dpdk.org,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
Ameen Rahman <ameen.rahman@qlogic.com>,
Sony Chacko <sony.chacko@qlogic.com>
Subject: Re: [dpdk-dev] [PATCH v5 10/10] qede: Enable PMD build
Date: Wed, 20 Apr 2016 10:25:03 +0100 [thread overview]
Message-ID: <20160420092502.GB4080@bricha3-MOBL3> (raw)
In-Reply-To: <2411922.nRbcghIYQB@xps13>
On Wed, Apr 20, 2016 at 10:51:06AM +0200, Thomas Monjalon wrote:
> 2016-04-20 00:14, Harish Patil:
> > >2016-03-31 19:15, Rasesh Mody:
> > >> --- a/config/common_base
> > >> +++ b/config/common_base
> > >> +CONFIG_RTE_LIBRTE_QEDE_RX_COAL_US=24
> > >> +CONFIG_RTE_LIBRTE_QEDE_TX_COAL_US=48
> > >
> > >It looks to be some tuning which could be done at runtime. Isn't it?
> >
> > That’s right. Can you please suggest if there is any better option to make
> > it a runtime? There is no PMD API for that.
>
> There are some devargs for that.
> For PCI dev, it can be passed in the whitelist option.
> We should remove this limitation by having a devargs API (and command line
> options) independent of whitelisting.
But back to the original setting. Are these likely to be values that are tunable
or need to be tunable by the user? If not, I see little reason to make them
run-time configurable - they could be defines inside the driver itself.
/Bruce
next prev parent reply other threads:[~2016-04-20 9:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 2:15 [dpdk-dev] [PATCH v5 00/10] qede: Add qede PMD Rasesh Mody
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 01/10] qede: Add maintainers Rasesh Mody
2016-04-18 16:41 ` Thomas Monjalon
2016-04-18 21:40 ` Harish Patil
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 02/10] qede: Add documentation Rasesh Mody
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 03/10] qede: Add license file Rasesh Mody
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 04/10] qede: Add base driver Rasesh Mody
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 05/10] qede: Add core driver Rasesh Mody
2016-04-01 15:41 ` Stephen Hemminger
2016-04-01 15:42 ` Stephen Hemminger
2016-04-19 12:35 ` Thomas Monjalon
2016-04-19 12:59 ` Thomas Monjalon
2016-04-20 1:09 ` Rasesh Mody
2016-04-20 8:54 ` Thomas Monjalon
2016-04-22 10:48 ` [dpdk-dev] Compiler minimum versions. (Was: [PATCH v5 05/10] qede: Add core driver) Bruce Richardson
2016-04-19 13:18 ` [dpdk-dev] [PATCH v5 05/10] qede: Add core driver Thomas Monjalon
2016-04-20 1:10 ` Rasesh Mody
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 06/10] qede: Add L2 support Rasesh Mody
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 07/10] qede: Add SRIOV support Rasesh Mody
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 08/10] qede: Add attention support Rasesh Mody
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 09/10] qede: Add DCBX support Rasesh Mody
2016-04-19 12:51 ` Thomas Monjalon
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 10/10] qede: Enable PMD build Rasesh Mody
2016-04-18 15:34 ` Thomas Monjalon
2016-04-20 0:07 ` Harish Patil
2016-04-18 15:37 ` Thomas Monjalon
2016-04-20 0:14 ` Harish Patil
2016-04-20 8:51 ` Thomas Monjalon
2016-04-20 9:25 ` Bruce Richardson [this message]
2016-04-20 16:43 ` Harish Patil
2016-04-21 10:01 ` Bruce Richardson
2016-04-20 16:36 ` Harish Patil
2016-04-01 15:44 ` [dpdk-dev] [PATCH v5 00/10] qede: Add qede PMD Stephen Hemminger
2016-04-01 15:51 ` Harish Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420092502.GB4080@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=ameen.rahman@qlogic.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
--cc=rasesh.mody@qlogic.com \
--cc=sony.chacko@qlogic.com \
--cc=stephen@networkplumber.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).