From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 321492C37 for <dev@dpdk.org>; Wed, 20 Apr 2016 11:25:08 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 20 Apr 2016 02:25:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,509,1455004800"; d="scan'208";a="962579414" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.132]) by fmsmga002.fm.intel.com with SMTP; 20 Apr 2016 02:25:03 -0700 Received: by (sSMTP sendmail emulation); Wed, 20 Apr 2016 10:25:03 +0025 Date: Wed, 20 Apr 2016 10:25:03 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: Thomas Monjalon <thomas.monjalon@6wind.com> Cc: Harish Patil <harish.patil@qlogic.com>, Rasesh Mody <rasesh.mody@qlogic.com>, dev@dpdk.org, "stephen@networkplumber.org" <stephen@networkplumber.org>, Ameen Rahman <ameen.rahman@qlogic.com>, Sony Chacko <sony.chacko@qlogic.com> Message-ID: <20160420092502.GB4080@bricha3-MOBL3> References: <1459476927-21387-1-git-send-email-rasesh.mody@qlogic.com> <4202835.rtEgrshY1X@xps13> <D33C1655.1A8490%harish.patil@qlogic.com> <2411922.nRbcghIYQB@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2411922.nRbcghIYQB@xps13> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v5 10/10] qede: Enable PMD build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 20 Apr 2016 09:25:08 -0000 On Wed, Apr 20, 2016 at 10:51:06AM +0200, Thomas Monjalon wrote: > 2016-04-20 00:14, Harish Patil: > > >2016-03-31 19:15, Rasesh Mody: > > >> --- a/config/common_base > > >> +++ b/config/common_base > > >> +CONFIG_RTE_LIBRTE_QEDE_RX_COAL_US=24 > > >> +CONFIG_RTE_LIBRTE_QEDE_TX_COAL_US=48 > > > > > >It looks to be some tuning which could be done at runtime. Isn't it? > > > > That’s right. Can you please suggest if there is any better option to make > > it a runtime? There is no PMD API for that. > > There are some devargs for that. > For PCI dev, it can be passed in the whitelist option. > We should remove this limitation by having a devargs API (and command line > options) independent of whitelisting. But back to the original setting. Are these likely to be values that are tunable or need to be tunable by the user? If not, I see little reason to make them run-time configurable - they could be defines inside the driver itself. /Bruce