From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wes1-so2.wedos.net (wes1-so2.wedos.net [46.28.106.16]) by dpdk.org (Postfix) with ESMTP id 77E912BF8 for ; Wed, 20 Apr 2016 14:43:22 +0200 (CEST) Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz [147.229.13.147]) by wes1-so2.wedos.net (Postfix) with ESMTPSA id 3qqhPk1vFrz1st; Wed, 20 Apr 2016 14:43:22 +0200 (CEST) Date: Wed, 20 Apr 2016 14:41:18 +0200 From: Jan Viktorin To: Bruce Richardson Cc: David Marchand , dev@dpdk.org, thomas.monjalon@6wind.com Message-ID: <20160420144118.16003a63@pcviktorin.fit.vutbr.cz> In-Reply-To: <20160420120524.GA2020@bricha3-MOBL3> References: <1454076516-21591-1-git-send-email-david.marchand@6wind.com> <1461152657-19969-1-git-send-email-david.marchand@6wind.com> <20160420120524.GA2020@bricha3-MOBL3> Organization: RehiveTech MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 00/17] prepare for rte_device / rte_driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2016 12:43:22 -0000 On Wed, 20 Apr 2016 13:05:24 +0100 Bruce Richardson wrote: > On Wed, Apr 20, 2016 at 01:44:00PM +0200, David Marchand wrote: > > Following discussions with Jan [1] and some cleanup I started on pci code, > > here is a patchset that reworks pdev drivers registration and hotplug api. > > > > The structures changes mentioned in [1] are still to be done, but at least, > > I think we are one step closer to it. > > > > Before this patchset, rte_driver .init semantics differed whether it > > concerned a pdev or a vdev driver: > > - for vdev, it actually meant that a devargs is given to the driver so > > that it creates ethdev / crypto objects, so it was a probing action > > - for pdev, it only registered the driver triggering no ethdev / crypto > > objects > > > > From my pov, eal hotplug api introduced in this patchset still needs more > > work so that it does not need to know about devargs. So a new devargs api > > is needed. > > > > Changes since v1: > > - rebased on HEAD, new drivers should be okay > > - patches have been split into smaller pieces > > - RTE_INIT macro has been added, but in the end, I am not sure it is useful > > - device type has been removed from ethdev, as it was used only by hotplug > > - getting rid of pmd type in eal patch (patch 5 of initial series) has been > > dropped for now, we can do this once vdev drivers have been converted > > > > [1] http://dpdk.org/ml/archives/dev/2016-January/031390.html > > > > Regards, > > -- > > David Marchand > > > Nice, David. Looks to be some good improvements in there! > > /Bruce Looks good for me but I've failed to apply the series on top of commit 7d619406f31ddf115714b32778c33f6dc0ead470 Author: Thomas Monjalon Date: Thu Apr 14 20:49:49 2016 +0200 pci: remove deprecated specific config Jan