* [dpdk-dev] [PATCH v1] drivers/net/i40e: fix incorrect register dump offset
@ 2016-04-13 9:44 Remy Horton
2016-04-14 3:08 ` Wu, Jingjing
0 siblings, 1 reply; 3+ messages in thread
From: Remy Horton @ 2016-04-13 9:44 UTC (permalink / raw)
To: helin.zhang; +Cc: dev
The position of register values within i40e register dumps is
supposed to reflect the register addresses. These were not being
correctly calculated.
Fixes: d9efd0136ac1 ("i40e: add EEPROM and registers dumping")
Signed-off-by: Remy Horton <remy.horton@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index bc28d3c..fc3a1d0 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -9031,6 +9031,7 @@ static int i40e_get_regs(struct rte_eth_dev *dev,
arr_idx2++) {
reg_offset = arr_idx * reg_info->stride1 +
arr_idx2 * reg_info->stride2;
+ reg_offset += reg_info->base_addr;
ptr_data[reg_offset >> 2] =
i40e_read_rx_ctl(hw, reg_offset);
}
@@ -9046,6 +9047,7 @@ static int i40e_get_regs(struct rte_eth_dev *dev,
arr_idx2++) {
reg_offset = arr_idx * reg_info->stride1 +
arr_idx2 * reg_info->stride2;
+ reg_offset += reg_info->base_addr;
ptr_data[reg_offset >> 2] =
I40E_READ_REG(hw, reg_offset);
}
--
2.5.5
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH v1] drivers/net/i40e: fix incorrect register dump offset
2016-04-13 9:44 [dpdk-dev] [PATCH v1] drivers/net/i40e: fix incorrect register dump offset Remy Horton
@ 2016-04-14 3:08 ` Wu, Jingjing
2016-04-20 14:44 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Wu, Jingjing @ 2016-04-14 3:08 UTC (permalink / raw)
To: Horton, Remy, Zhang, Helin; +Cc: dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Remy Horton
> Sent: Wednesday, April 13, 2016 5:45 PM
> To: Zhang, Helin
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v1] drivers/net/i40e: fix incorrect register dump
> offset
>
> The position of register values within i40e register dumps is supposed to
> reflect the register addresses. These were not being correctly calculated.
>
> Fixes: d9efd0136ac1 ("i40e: add EEPROM and registers dumping")
>
> Signed-off-by: Remy Horton <remy.horton@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Thanks
Jingjing
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH v1] drivers/net/i40e: fix incorrect register dump offset
2016-04-14 3:08 ` Wu, Jingjing
@ 2016-04-20 14:44 ` Bruce Richardson
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2016-04-20 14:44 UTC (permalink / raw)
To: Wu, Jingjing; +Cc: Horton, Remy, Zhang, Helin, dev
On Thu, Apr 14, 2016 at 03:08:07AM +0000, Wu, Jingjing wrote:
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Remy Horton
> > Sent: Wednesday, April 13, 2016 5:45 PM
> > To: Zhang, Helin
> > Cc: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH v1] drivers/net/i40e: fix incorrect register dump
> > offset
> >
> > The position of register values within i40e register dumps is supposed to
> > reflect the register addresses. These were not being correctly calculated.
> >
> > Fixes: d9efd0136ac1 ("i40e: add EEPROM and registers dumping")
> >
> > Signed-off-by: Remy Horton <remy.horton@intel.com>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
>
Applied to dpdk-next-net/rel_16_07
Thanks,
/Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-20 14:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-13 9:44 [dpdk-dev] [PATCH v1] drivers/net/i40e: fix incorrect register dump offset Remy Horton
2016-04-14 3:08 ` Wu, Jingjing
2016-04-20 14:44 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).