From: Stephen Hemminger <stephen@networkplumber.org>
To: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Cc: anatoly.burakov@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: fix unchecked return value from library
Date: Thu, 21 Apr 2016 09:05:46 -0700 [thread overview]
Message-ID: <20160421090546.532b1201@xeon-e3> (raw)
In-Reply-To: <1461239817-96357-1-git-send-email-danielx.t.mrzyglod@intel.com>
On Thu, 21 Apr 2016 13:56:57 +0200
Daniel Mrzyglod <danielx.t.mrzyglod@intel.com> wrote:
> + if (setsockopt(conn_sock, SOL_SOCKET, SO_LINGER, &l, sizeof(l)) < 0)
> + RTE_LOG(ERR, EAL, "Cannot set SO_LINGER option "
> + "on listen socket (%s)\n", strerror(errno));
Priority should be WARNING not ERR because it has no real impact on the application
usability
level
This determines the importance of the message. The levels are, in
order of decreasing importance:
LOG_EMERG system is unusable
LOG_ALERT action must be taken immediately
LOG_CRIT critical conditions
LOG_ERR error conditions
LOG_WARNING warning conditions
LOG_NOTICE normal, but significant, condition
LOG_INFO informational message
LOG_DEBUG debug-level message
next prev parent reply other threads:[~2016-04-21 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 11:56 Daniel Mrzyglod
2016-04-21 11:06 ` Burakov, Anatoly
2016-04-21 16:05 ` Stephen Hemminger [this message]
2016-04-22 13:17 ` [dpdk-dev] [PATCH v2] " Daniel Mrzyglod
2016-04-27 14:03 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421090546.532b1201@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=danielx.t.mrzyglod@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).