From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com [209.85.220.44]) by dpdk.org (Postfix) with ESMTP id 295A8CE7 for ; Thu, 21 Apr 2016 18:05:35 +0200 (CEST) Received: by mail-pa0-f44.google.com with SMTP id r5so27567259pag.1 for ; Thu, 21 Apr 2016 09:05:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oanW5yxu8aoaNcTCBp4fybI/eW0v7aF4d5dKk8cp6TA=; b=abIDKhtcNKVvYNHU8ACjWzrx5EijEV+fiY/SzdI/LPGnTDbTIt8DGHY7vuLBhpE9ha SKV1HLel5UrNwCQw/y9UdmsWHLu8uTvZljuTN+ZExEsE9UQn1PzmaMTaDPBG/lzV62cM fY/E4N/3+w0/wHh8VMDIlk62yKS7Dp2vAyhyyQqWPWfC1C3eMWlu2cqszcZJd4iLVRf2 Z1PwocQw7/nT/g3MMa7kNgvmm9UpxpBLff+kzJ5DeyT098/ZCb4eI0N7lcRW+ckkzdDv FmkjkfsgZMpPn8A3SezT7oS0Wl6UIxz/jajbVzbMivjnXYFsJFgzMLQ/cXoZES1WzeZl sQPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oanW5yxu8aoaNcTCBp4fybI/eW0v7aF4d5dKk8cp6TA=; b=S2HNIrHFxnsDl+1fBKVU1pEtNrIm686tv6wHZ7Ge3d1X34MKzm2xh/3+GjYu21xhp1 Wf8jBuMEux2Nksxo8QIhuFsak14bguuNJx/SmCVCFmV2Cg3u0ylQJDONhjlPFXFXfvvp e3BEXZBQ/Zc2qecQwTILiFtVP425yfm4uoBf7PehAMpZOoeyQdJG1OeLxIr2DYOGtF94 A4AsYIrx+2M7NcgSVZi9IdT7t0NHMoYr3QoWX9BjUllKZP/tNsCXqceXKBF0l2xnX9qc 3kuq/dbQwGzkFBFKGERznKEKPp5ntd4kydmeGAK4jpN+3sgwItKZq2OaeQT86ol8y8Kp bNsw== X-Gm-Message-State: AOPr4FXRt7ravCKBtVr1YgTf7yeyUeednngiZKcAg6hIUdkG7VQeuri1awqCamrDWsnuEA== X-Received: by 10.66.122.139 with SMTP id ls11mr21786590pab.14.1461254734441; Thu, 21 Apr 2016 09:05:34 -0700 (PDT) Received: from xeon-e3 (static-50-53-72-186.bvtn.or.frontiernet.net. [50.53.72.186]) by smtp.gmail.com with ESMTPSA id a5sm3211876pat.19.2016.04.21.09.05.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Apr 2016 09:05:33 -0700 (PDT) Date: Thu, 21 Apr 2016 09:05:46 -0700 From: Stephen Hemminger To: Daniel Mrzyglod Cc: anatoly.burakov@intel.com, dev@dpdk.org Message-ID: <20160421090546.532b1201@xeon-e3> In-Reply-To: <1461239817-96357-1-git-send-email-danielx.t.mrzyglod@intel.com> References: <1461239817-96357-1-git-send-email-danielx.t.mrzyglod@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: fix unchecked return value from library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Apr 2016 16:05:35 -0000 On Thu, 21 Apr 2016 13:56:57 +0200 Daniel Mrzyglod wrote: > + if (setsockopt(conn_sock, SOL_SOCKET, SO_LINGER, &l, sizeof(l)) < 0) > + RTE_LOG(ERR, EAL, "Cannot set SO_LINGER option " > + "on listen socket (%s)\n", strerror(errno)); Priority should be WARNING not ERR because it has no real impact on the application usability level This determines the importance of the message. The levels are, in order of decreasing importance: LOG_EMERG system is unusable LOG_ALERT action must be taken immediately LOG_CRIT critical conditions LOG_ERR error conditions LOG_WARNING warning conditions LOG_NOTICE normal, but significant, condition LOG_INFO informational message LOG_DEBUG debug-level message