From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id E6F652C16
 for <dev@dpdk.org>; Thu, 21 Apr 2016 16:05:13 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga103.jf.intel.com with ESMTP; 21 Apr 2016 07:05:13 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,513,1455004800"; d="scan'208";a="959833100"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.132])
 by orsmga002.jf.intel.com with SMTP; 21 Apr 2016 07:05:08 -0700
Received: by  (sSMTP sendmail emulation); Thu, 21 Apr 2016 15:05:07 +0025
Date: Thu, 21 Apr 2016 15:05:07 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: "Azarewicz, PiotrX T" <piotrx.t.azarewicz@intel.com>,
 "Zhang, Helin" <helin.zhang@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20160421140506.GB3808@bricha3-MOBL3>
References: <1460627970-20864-1-git-send-email-piotrx.t.azarewicz@intel.com>
 <6A0DE07E22DDAD4C9103DF62FEBC090903455895@shsmsx102.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC090903455895@shsmsx102.ccr.corp.intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v1 1/1] ixgbe: fix queue stop
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Apr 2016 14:05:14 -0000

On Fri, Apr 15, 2016 at 01:31:03AM +0000, Lu, Wenzhuo wrote:
> Hi,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Piotr Azarewicz
> > Sent: Thursday, April 14, 2016 6:00 PM
> > To: Zhang, Helin; Ananyev, Konstantin
> > Cc: dev@dpdk.org; Azarewicz, PiotrX T
> > Subject: [dpdk-dev] [PATCH v1 1/1] ixgbe: fix queue stop
> > 
> > It should be checked if queue enable bit is clear.
> > 
> > CID 13215 : Wrong operator used (CONSTANT_EXPRESSION_RESULT)
> > operator_confusion: txdctl | 33554432 is always 1/true regardless of the values
> > of its operand. This occurs as the logical second operand of '&&'.
> > 
> > CID 13216 : Wrong operator used (CONSTANT_EXPRESSION_RESULT)
> > operator_confusion: rxdctl | 33554432 is always 1/true regardless of the values
> > of its operand. This occurs as the logical second operand of '&&'.
> > 
> > Coverity issue: 13215
> > Coverity issue: 13216
> > Fixes: 029fd06d40fa ("ixgbe: queue start and stop")
> > 
> > Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Sometimes machine is smarter than human :)  Thanks Piotr for handling this.

Applied to dpdk-next-net/rel_16_07

/Bruce