* [dpdk-dev] [PATCH] i40e: fix packet stats getting
@ 2016-04-19 6:11 Jingjing Wu
2016-04-19 6:21 ` Zhang, Helin
0 siblings, 1 reply; 3+ messages in thread
From: Jingjing Wu @ 2016-04-19 6:11 UTC (permalink / raw)
To: bruce.richardson; +Cc: dev, jingjing.wu, helin.zhang
The statistics queried by calling rte_eth_stats_get are zero when
the API is first called on the port. The root cause is because of
offset_loaded flag is not set correctly after device started.
This patch fixes this issue by resetting statistics at initialization
time, at the meanwhile the resetting process will set offset_loaded
flag.
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index bc28d3c..3aaef07 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -934,6 +934,9 @@ eth_i40e_dev_init(struct rte_eth_dev *dev)
goto err_setup_pf_switch;
}
+ /* reset all stats of the device, including pf and main vsi */
+ i40e_dev_stats_reset(dev);
+
vsi = pf->main_vsi;
/* Disable double vlan by default */
--
2.4.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] i40e: fix packet stats getting
2016-04-19 6:11 [dpdk-dev] [PATCH] i40e: fix packet stats getting Jingjing Wu
@ 2016-04-19 6:21 ` Zhang, Helin
2016-04-21 14:14 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Helin @ 2016-04-19 6:21 UTC (permalink / raw)
To: Wu, Jingjing, Richardson, Bruce; +Cc: dev
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Tuesday, April 19, 2016 2:11 PM
> To: Richardson, Bruce <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin
> <helin.zhang@intel.com>
> Subject: [PATCH] i40e: fix packet stats getting
>
> The statistics queried by calling rte_eth_stats_get are zero when the API is first
> called on the port. The root cause is because of offset_loaded flag is not set
> correctly after device started.
> This patch fixes this issue by resetting statistics at initialization time, at the
> meanwhile the resetting process will set offset_loaded flag.
>
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] i40e: fix packet stats getting
2016-04-19 6:21 ` Zhang, Helin
@ 2016-04-21 14:14 ` Bruce Richardson
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2016-04-21 14:14 UTC (permalink / raw)
To: Zhang, Helin; +Cc: Wu, Jingjing, dev
On Tue, Apr 19, 2016 at 07:21:16AM +0100, Zhang, Helin wrote:
>
>
> > -----Original Message-----
> > From: Wu, Jingjing
> > Sent: Tuesday, April 19, 2016 2:11 PM
> > To: Richardson, Bruce <bruce.richardson@intel.com>
> > Cc: dev@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin
> > <helin.zhang@intel.com>
> > Subject: [PATCH] i40e: fix packet stats getting
> >
> > The statistics queried by calling rte_eth_stats_get are zero when the API is first
> > called on the port. The root cause is because of offset_loaded flag is not set
> > correctly after device started.
> > This patch fixes this issue by resetting statistics at initialization time, at the
> > meanwhile the resetting process will set offset_loaded flag.
> >
> > Fixes: 4861cde46116 ("i40e: new poll mode driver")
> > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
>
Applied to dpdk-next-net/rel_16_07
/Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-21 14:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-19 6:11 [dpdk-dev] [PATCH] i40e: fix packet stats getting Jingjing Wu
2016-04-19 6:21 ` Zhang, Helin
2016-04-21 14:14 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).