From: Bruce Richardson <bruce.richardson@intel.com>
To: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Cc: wenzhuo.lu@intel.com, helin.zhang@intel.com,
konstantin.ananyev@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix bad shift operation in ixgbe_set_pool_rx/tx
Date: Mon, 25 Apr 2016 11:35:44 +0100 [thread overview]
Message-ID: <20160425103543.GA18116@bricha3-MOBL3> (raw)
In-Reply-To: <1461339357-8048-1-git-send-email-tomaszx.kulasek@intel.com>
On Fri, Apr 22, 2016 at 05:35:57PM +0200, Tomasz Kulasek wrote:
> Fix issue reported by Coverity.
>
> Coverity ID 13193: Bad bit shift operation (BAD_SHIFT)
> large_shift: In expression 1 << pool, left shifting by more than 31 bits
> has undefined behavior. The shift amount, pool, is at least 32.
>
> This patch is a rework of register addr selection logic and mask
> computation to made it more readable and avoid bit overflow when 32 bit
> value is shifted over its size for pool > 31.
>
> Fixes: fe3a45fd4104 ("ixgbe: add VMDq support")
>
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2016-04-25 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 13:39 [dpdk-dev] [PATCH] ixgbe: fix bad shift operation in ixgbe_set_pool_rx Tomasz Kulasek
2016-04-18 1:57 ` Lu, Wenzhuo
2016-04-21 13:51 ` Bruce Richardson
2016-04-21 14:44 ` Kulasek, TomaszX
2016-04-21 15:28 ` Bruce Richardson
2016-04-22 13:27 ` Kulasek, TomaszX
2016-04-22 15:35 ` [dpdk-dev] [PATCH v2] ixgbe: fix bad shift operation in ixgbe_set_pool_rx/tx Tomasz Kulasek
2016-04-25 10:35 ` Bruce Richardson [this message]
2016-04-25 10:38 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425103543.GA18116@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=tomaszx.kulasek@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).