From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 4E1BD3208
 for <dev@dpdk.org>; Tue, 26 Apr 2016 05:44:58 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga104.fm.intel.com with ESMTP; 25 Apr 2016 20:44:57 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,535,1455004800"; d="scan'208";a="966480246"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by fmsmga002.fm.intel.com with ESMTP; 25 Apr 2016 20:44:56 -0700
Date: Mon, 25 Apr 2016 20:47:10 -0700
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: Tetsuya Mukawa <mukawa@igel.co.jp>, "dev@dpdk.org" <dev@dpdk.org>,
 "Xie, Huawei" <huawei.xie@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20160426034710.GD7832@yliu-dev.sh.intel.com>
References: <571DDDD8.6000000@igel.co.jp>
 <571DE345.4000609@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <571DE345.4000609@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [RFC] Link ibrte_vhost to librte_pmd_vhost
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Apr 2016 03:44:58 -0000

On Mon, Apr 25, 2016 at 12:28:37PM +0300, Panu Matilainen wrote:
 >
> >Another way is applying a below patch.
> >--- a/drivers/net/vhost/Makefile
> >+++ b/drivers/net/vhost/Makefile
> >@@ -38,6 +38,7 @@ LIB = librte_pmd_vhost.a
> >
> >  CFLAGS += -O3
> >  CFLAGS += $(WERROR_FLAGS)
> >+LDLIBS += -lrte_vhost
> >
> >  EXPORT_MAP := rte_pmd_vhost_version.map
> >
> >This is same way to link libpcap to librte_pmd_pcap.
> >What do you think about adding it to vhost PMD?
> 
> Yes, this is absolutely the right thing to do.
> 
> Ultimately this should be done for all dependencies in all libraries, but
> missing dependencies are even more pronounced in plugins so the sooner this
> goes in, the better.
> 
> Acked-by: Panu Matilainen <pmatilai@redhat.com>

Panu, thanks for the input.

Tetsuya, please submit a formal patch so that I can merge.

	--yliu