From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id A67D5DE0
 for <dev@dpdk.org>; Tue, 26 Apr 2016 07:46:31 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga103.fm.intel.com with ESMTP; 25 Apr 2016 22:46:30 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,535,1455004800"; d="scan'208";a="962747593"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by orsmga002.jf.intel.com with ESMTP; 25 Apr 2016 22:46:29 -0700
Date: Mon, 25 Apr 2016 22:48:44 -0700
From: Yuanhan Liu <yuanhan.liu@intel.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Cc: Panu Matilainen <pmatilai@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Xie, Huawei" <huawei.xie@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20160426054844.GF7832@yliu-dev.sh.intel.com>
References: <571DDDD8.6000000@igel.co.jp> <571DE345.4000609@redhat.com>
 <20160426034710.GD7832@yliu-dev.sh.intel.com>
 <571EFEA1.5080006@igel.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <571EFEA1.5080006@igel.co.jp>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [RFC] Link ibrte_vhost to librte_pmd_vhost
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Apr 2016 05:46:32 -0000

On Tue, Apr 26, 2016 at 02:37:37PM +0900, Tetsuya Mukawa wrote:
> On 2016/04/26 12:47, Yuanhan Liu wrote:
> > On Mon, Apr 25, 2016 at 12:28:37PM +0300, Panu Matilainen wrote:
> >  >
> >>> Another way is applying a below patch.
> >>> --- a/drivers/net/vhost/Makefile
> >>> +++ b/drivers/net/vhost/Makefile
> >>> @@ -38,6 +38,7 @@ LIB = librte_pmd_vhost.a
> >>>
> >>>  CFLAGS += -O3
> >>>  CFLAGS += $(WERROR_FLAGS)
> >>> +LDLIBS += -lrte_vhost
> >>>
> >>>  EXPORT_MAP := rte_pmd_vhost_version.map
> >>>
> >>> This is same way to link libpcap to librte_pmd_pcap.
> >>> What do you think about adding it to vhost PMD?
> >> Yes, this is absolutely the right thing to do.
> >>
> >> Ultimately this should be done for all dependencies in all libraries, but
> >> missing dependencies are even more pronounced in plugins so the sooner this
> >> goes in, the better.
> >>
> >> Acked-by: Panu Matilainen <pmatilai@redhat.com>
> > Panu, thanks for the input.
> >
> > Tetsuya, please submit a formal patch so that I can merge.
> >
> > 	--yliu
> 
> Hi Yuanhan,
> 
> Oh sorry, I forgot to add "--in-reply-to" while sending the patch, so
> you may miss it.
> Also the order of Acked-by and Signed-off-by was wrong in above patch.
> So I will send v2 soon.

No worry. I could fix them, and I don't think there is a very strict
rule for both of them :) BTW, FYI, I just found my linux.intel.com
seems to be broken (no idea why), thus I made late response.

(well, I found you just send a v2; I will apply that tomorrow).

	--yliu