From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id D31FF2A1A
 for <dev@dpdk.org>; Tue, 26 Apr 2016 16:56:11 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga102.fm.intel.com with ESMTP; 26 Apr 2016 07:56:10 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,537,1455004800"; d="scan'208";a="92236712"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.45])
 by fmsmga004.fm.intel.com with SMTP; 26 Apr 2016 07:56:09 -0700
Received: by  (sSMTP sendmail emulation); Tue, 26 Apr 2016 15:56:07 +0025
Date: Tue, 26 Apr 2016 15:56:07 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: thomas.monjalon@6wind.com, dev@dpdk.org, ameen.rahman@qlogic.com,
 Harish Patil <harish.patil@qlogic.com>,
 Sony Chacko <sony.chacko@qlogic.com>
Message-ID: <20160426145607.GB10896@bricha3-MOBL3>
References: <1461647586-22234-1-git-send-email-rasesh.mody@qlogic.com>
 <1461647586-22234-8-git-send-email-rasesh.mody@qlogic.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1461647586-22234-8-git-send-email-rasesh.mody@qlogic.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v6 8/8] qede: Enable PMD build
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Apr 2016 14:56:12 -0000

On Mon, Apr 25, 2016 at 10:13:06PM -0700, Rasesh Mody wrote:
> This patch enables the QEDE PMD build.
> 
> Signed-off-by: Harish Patil <harish.patil@qlogic.com>
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> Signed-off-by: Sony Chacko <sony.chacko@qlogic.com>
> ---
>  config/common_base   |   12 ++++++++++++
>  drivers/net/Makefile |    1 +
>  mk/rte.app.mk        |    2 ++
>  3 files changed, 15 insertions(+)
> 
Without any other changes, this patch can be placed two patches earlier in the
series, i.e. before the attention support and DCBX features are added in. Ideally,
it would be good to have this patch just after the core driver is added in patch
3, but I suspect that that may be infeasible, so please just move it to the
earliest point in the series where the code can reasonably compile.

thanks,
/Bruce