From: Bruce Richardson <bruce.richardson@intel.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: thomas.monjalon@6wind.com, dev@dpdk.org, ameen.rahman@qlogic.com,
Harish Patil <harish.patil@qlogic.com>,
Sony Chacko <sony.chacko@qlogic.com>,
john.mcnamara@intel.com
Subject: Re: [dpdk-dev] [PATCH v6 1/8] qede: Add maintainers, documentation and license
Date: Tue, 26 Apr 2016 16:04:23 +0100 [thread overview]
Message-ID: <20160426150423.GC10896@bricha3-MOBL3> (raw)
In-Reply-To: <1461647586-22234-1-git-send-email-rasesh.mody@qlogic.com>
On Mon, Apr 25, 2016 at 10:12:59PM -0700, Rasesh Mody wrote:
> Signed-off-by: Harish Patil <harish.patil@qlogic.com>
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> Signed-off-by: Sony Chacko <sony.chacko@qlogic.com>
> ---
> MAINTAINERS | 7 +
> doc/guides/nics/index.rst | 1 +
> doc/guides/nics/overview.rst | 86 +++++-----
> doc/guides/nics/qede.rst | 314 +++++++++++++++++++++++++++++++++++++
> drivers/net/qede/LICENSE.qede_pmd | 28 ++++
> 5 files changed, 393 insertions(+), 43 deletions(-)
> create mode 100644 doc/guides/nics/qede.rst
> create mode 100644 drivers/net/qede/LICENSE.qede_pmd
>
Hi,
While it's great to see the documentation for each driver coming in the same
patchset as the driver itself, can you perhaps see about merging some of the doc
changes here in with the other patches. For example, the license and maintainers
changes can probably go with the base code drop, while the NIC overview
documentation should go with the core code for the driver.
Ideally, the feature matrix would be updated as each patch adds new features,
but since this is a new driver, I'm ok with just having this as part of that
core driver patch too - with a note in the commit stating that the following
commits contain the code for the features not implemented in that one.
Thomas, John McNamara, as keen viewers and maintainers of our documentation,
any comments or strong objection to this?
Regards,
/Bruce
next prev parent reply other threads:[~2016-04-26 15:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 5:12 Rasesh Mody
2016-04-26 5:13 ` [dpdk-dev] [PATCH v6 2/8] qede: Add base driver Rasesh Mody
2016-04-26 13:01 ` Bruce Richardson
2016-04-27 0:49 ` Rasesh Mody
2016-04-26 13:16 ` Bruce Richardson
2016-04-26 5:13 ` [dpdk-dev] [PATCH v6 3/8] qede: Add core driver Rasesh Mody
2016-04-26 5:13 ` [dpdk-dev] [PATCH v6 4/8] qede: Add L2 support Rasesh Mody
2016-04-26 5:13 ` [dpdk-dev] [PATCH v6 5/8] qede: Add SRIOV support Rasesh Mody
2016-04-26 5:13 ` [dpdk-dev] [PATCH v6 6/8] qede: Add attention support Rasesh Mody
2016-04-26 13:25 ` Bruce Richardson
2016-04-26 5:13 ` [dpdk-dev] [PATCH v6 7/8] qede: Add DCBX support Rasesh Mody
2016-04-26 5:13 ` [dpdk-dev] [PATCH v6 8/8] qede: Enable PMD build Rasesh Mody
2016-04-26 14:56 ` Bruce Richardson
2016-04-26 13:03 ` [dpdk-dev] [PATCH v6 1/8] qede: Add maintainers, documentation and license Bruce Richardson
2016-04-26 18:27 ` Rasesh Mody
2016-04-26 19:33 ` Thomas Monjalon
2016-04-26 19:35 ` Rasesh Mody
2016-04-26 15:04 ` Bruce Richardson [this message]
2016-04-26 15:19 ` Mcnamara, John
2016-04-26 15:40 ` Thomas Monjalon
2016-04-26 15:49 ` Mcnamara, John
2016-04-27 0:21 ` Rasesh Mody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426150423.GC10896@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=ameen.rahman@qlogic.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
--cc=john.mcnamara@intel.com \
--cc=rasesh.mody@qlogic.com \
--cc=sony.chacko@qlogic.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).