From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 320BB2B96 for ; Tue, 26 Apr 2016 17:06:08 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 26 Apr 2016 08:04:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,537,1455004800"; d="scan'208";a="92241418" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.45]) by fmsmga004.fm.intel.com with SMTP; 26 Apr 2016 08:04:24 -0700 Received: by (sSMTP sendmail emulation); Tue, 26 Apr 2016 16:04:23 +0025 Date: Tue, 26 Apr 2016 16:04:23 +0100 From: Bruce Richardson To: Rasesh Mody Cc: thomas.monjalon@6wind.com, dev@dpdk.org, ameen.rahman@qlogic.com, Harish Patil , Sony Chacko , john.mcnamara@intel.com Message-ID: <20160426150423.GC10896@bricha3-MOBL3> References: <1461647586-22234-1-git-send-email-rasesh.mody@qlogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461647586-22234-1-git-send-email-rasesh.mody@qlogic.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v6 1/8] qede: Add maintainers, documentation and license X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2016 15:06:08 -0000 On Mon, Apr 25, 2016 at 10:12:59PM -0700, Rasesh Mody wrote: > Signed-off-by: Harish Patil > Signed-off-by: Rasesh Mody > Signed-off-by: Sony Chacko > --- > MAINTAINERS | 7 + > doc/guides/nics/index.rst | 1 + > doc/guides/nics/overview.rst | 86 +++++----- > doc/guides/nics/qede.rst | 314 +++++++++++++++++++++++++++++++++++++ > drivers/net/qede/LICENSE.qede_pmd | 28 ++++ > 5 files changed, 393 insertions(+), 43 deletions(-) > create mode 100644 doc/guides/nics/qede.rst > create mode 100644 drivers/net/qede/LICENSE.qede_pmd > Hi, While it's great to see the documentation for each driver coming in the same patchset as the driver itself, can you perhaps see about merging some of the doc changes here in with the other patches. For example, the license and maintainers changes can probably go with the base code drop, while the NIC overview documentation should go with the core code for the driver. Ideally, the feature matrix would be updated as each patch adds new features, but since this is a new driver, I'm ok with just having this as part of that core driver patch too - with a note in the commit stating that the following commits contain the code for the features not implemented in that one. Thomas, John McNamara, as keen viewers and maintainers of our documentation, any comments or strong objection to this? Regards, /Bruce