[dpdk-dev] [PATCH] i40e: Remove redundant fdir forward declarations.

[dpdk-dev] [PATCH] i40e: Remove redundant fdir forward declarations.

[Rami Rosen]

This patch removes several redundant forward declarations
in i40e_fdir.c.

Signed-off-by: Rami Rosen <rami.rosen@intel.com>
---
 drivers/net/i40e/i40e_fdir.c | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c
index f15a080..be3d0dd 100644
--- a/drivers/net/i40e/i40e_fdir.c
+++ b/drivers/net/i40e/i40e_fdir.c
@@ -113,29 +113,11 @@
 
 #define I40E_FLEX_WORD_MASK(off) (0x80 >> (off))
 
-static int i40e_fdir_rx_queue_init(struct i40e_rx_queue *rxq);
-static int i40e_check_fdir_flex_conf(
-	const struct rte_eth_fdir_flex_conf *conf);
-static void i40e_set_flx_pld_cfg(struct i40e_pf *pf,
-			 const struct rte_eth_flex_payload_cfg *cfg);
-static void i40e_set_flex_mask_on_pctype(struct i40e_pf *pf,
-		enum i40e_filter_pctype pctype,
-		const struct rte_eth_fdir_flex_mask *mask_cfg);
-static int i40e_fdir_construct_pkt(struct i40e_pf *pf,
-				     const struct rte_eth_fdir_input *fdir_input,
-				     unsigned char *raw_pkt);
-static int i40e_add_del_fdir_filter(struct rte_eth_dev *dev,
-			    const struct rte_eth_fdir_filter *filter,
-			    bool add);
 static int i40e_fdir_filter_programming(struct i40e_pf *pf,
 			enum i40e_filter_pctype pctype,
 			const struct rte_eth_fdir_filter *filter,
 			bool add);
 static int i40e_fdir_flush(struct rte_eth_dev *dev);
-static void i40e_fdir_info_get(struct rte_eth_dev *dev,
-			   struct rte_eth_fdir_info *fdir);
-static void i40e_fdir_stats_get(struct rte_eth_dev *dev,
-			   struct rte_eth_fdir_stats *stat);
 
 static int
 i40e_fdir_rx_queue_init(struct i40e_rx_queue *rxq)
-- 
2.4.3

Re: [dpdk-dev] [PATCH] i40e: Remove redundant fdir forward declarations.

[Thomas Monjalon]

2016-03-26 04:32, Rami Rosen:
> This patch removes several redundant forward declarations
> in i40e_fdir.c.

I have the feeling that writing some useless forward declarations
is common in some drivers.
So why removing only these ones? Are they the only one in i40e?

Re: [dpdk-dev] [PATCH] i40e: Remove redundant fdir forward declarations.

[Zhang, Helin]

> -----Original Message-----
> From: Rosen, Rami
> Sent: Saturday, March 26, 2016 9:32 AM
> To: Zhang, Helin
> Cc: dev@dpdk.org; Rosen, Rami
> Subject: [PATCH] i40e: Remove redundant fdir forward declarations.
> 
> This patch removes several redundant forward declarations in i40e_fdir.c.
> 
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>

Re: [dpdk-dev] [PATCH] i40e: Remove redundant fdir forward declarations.

[Bruce Richardson]

On Wed, Apr 27, 2016 at 02:51:55AM +0000, Zhang, Helin wrote:
> 
> 
> > -----Original Message-----
> > From: Rosen, Rami
> > Sent: Saturday, March 26, 2016 9:32 AM
> > To: Zhang, Helin
> > Cc: dev@dpdk.org; Rosen, Rami
> > Subject: [PATCH] i40e: Remove redundant fdir forward declarations.
> > 
> > This patch removes several redundant forward declarations in i40e_fdir.c.
> > 
> > Signed-off-by: Rami Rosen <rami.rosen@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>

Added fixes line:
Fixes: a778a1fa2e4e ("i40e: set up and initialize flow director")

Applied to dpdk-next-net/rel_16_04

If there are other unneeded forward declarations in this driver or other drivers,
as suggested by Thomas, please send on additional patches.

Thanks,
/bruce

Re: [dpdk-dev] [PATCH] i40e: Remove redundant fdir forward declarations.

[Richardson, Bruce]

> -----Original Message-----
> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> Sent: Wednesday, April 27, 2016 5:20 PM
> To: Zhang, Helin <helin.zhang@intel.com>
> Cc: Rosen, Rami <rami.rosen@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] i40e: Remove redundant fdir forward
> declarations.
> 
> On Wed, Apr 27, 2016 at 02:51:55AM +0000, Zhang, Helin wrote:
> >
> >
> > > -----Original Message-----
> > > From: Rosen, Rami
> > > Sent: Saturday, March 26, 2016 9:32 AM
> > > To: Zhang, Helin
> > > Cc: dev@dpdk.org; Rosen, Rami
> > > Subject: [PATCH] i40e: Remove redundant fdir forward declarations.
> > >
> > > This patch removes several redundant forward declarations in
> i40e_fdir.c.
> > >
> > > Signed-off-by: Rami Rosen <rami.rosen@intel.com>
> > Acked-by: Helin Zhang <helin.zhang@intel.com>
> 
> Added fixes line:
> Fixes: a778a1fa2e4e ("i40e: set up and initialize flow director")
> 
> Applied to dpdk-next-net/rel_16_04
> 
Where by 04 I obviously mean 07! :-)

/Bruce