DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Jasvinder Singh <jasvinder.singh@intel.com>
Cc: dev@dpdk.org, cristian.dumitrescu@intel.com
Subject: Re: [dpdk-dev] [PATCH] ip_pipeline: configuration file parser cleanup
Date: Tue, 3 May 2016 10:43:18 +0100	[thread overview]
Message-ID: <20160503094318.GB21300@bricha3-MOBL3> (raw)
In-Reply-To: <1462190035-63125-1-git-send-email-jasvinder.singh@intel.com>

On Mon, May 02, 2016 at 12:53:55PM +0100, Jasvinder Singh wrote:
> This patch updates the parsing routines of packet queues (pktq_in/out
> fields in the PIPELINE section) and message queues (msgq_in/out fields
> of in the MSGQ Section) specified in ip_pipeline configuration file.
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Hi Jasvinder,

can you provide more detail in the patch commit message, please? Why was this
cleanup wanted/needed, and how was it done? The code diff is pretty large so a
clear description of how the code works before and after this patch is needed
to help someone scanning the patch understand what is happening there.

Thanks,
/Bruce

  reply	other threads:[~2016-05-03  9:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-02 11:53 Jasvinder Singh
2016-05-03  9:43 ` Bruce Richardson [this message]
2016-05-03 13:58 ` [dpdk-dev] [PATCH v2] " Jasvinder Singh
2016-05-11 16:36   ` [dpdk-dev] [PATCH v3] " Jasvinder Singh
2016-05-30 14:33     ` [dpdk-dev] [PATCH v4] " Jasvinder Singh
2016-06-08 14:48       ` Thomas Monjalon
2016-06-08 16:24         ` Singh, Jasvinder
2016-06-08 16:30       ` [dpdk-dev] [PATCH v5] " Jasvinder Singh
2016-06-08 18:05         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160503094318.GB21300@bricha3-MOBL3 \
    --to=bruce.richardson@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).