From: Bruce Richardson <bruce.richardson@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "Mrzyglod, DanielX T" <danielx.t.mrzyglod@intel.com>,
"Chen, Jing D" <jing.d.chen@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] i40e: dereference before null check
Date: Tue, 3 May 2016 11:46:08 +0100 [thread overview]
Message-ID: <20160503104607.GA20328@bricha3-MOBL3> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F8E273BA@SHSMSX103.ccr.corp.intel.com>
On Wed, Apr 27, 2016 at 06:34:03AM +0000, Wu, Jingjing wrote:
>
>
> > -----Original Message-----
> > From: Mrzyglod, DanielX T
> > Sent: Tuesday, April 19, 2016 1:13 AM
> > To: Chen, Jing D; Wu, Jingjing; Zhang, Helin
> > Cc: dev@dpdk.org; Mrzyglod, DanielX T
> > Subject: [PATCH v2] i40e: dereference before null check
> >
> > Fix issue reported by Coverity.
> > Coverity ID 13302:
> > There may be a null pointer dereference, or else the comparison against null
> > is unnecessary.
> >
> > In i40evf_config_vlan_pvid: All paths that lead to this null pointer comparison
> > already dereference the pointer earlier
> >
> > Fixes: 2b12431b5369 ("i40e: add vlan stripping and insertion to VF")
> >
> > Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
>
Applied to dpdk-next-net/rel_16_07
/Bruce
prev parent reply other threads:[~2016-05-03 10:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 16:49 [dpdk-dev] [PATCH] " Daniel Mrzyglod
2016-04-18 15:55 ` Zhang, Helin
2016-04-18 17:13 ` [dpdk-dev] [PATCH v2] " Daniel Mrzyglod
2016-04-27 6:30 ` Zhang, Helin
2016-04-27 6:34 ` Wu, Jingjing
2016-05-03 10:46 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503104607.GA20328@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=danielx.t.mrzyglod@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jing.d.chen@intel.com \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).