From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 865302BAF
 for <dev@dpdk.org>; Tue,  3 May 2016 12:46:13 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga101.fm.intel.com with ESMTP; 03 May 2016 03:46:12 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,572,1455004800"; d="scan'208";a="971463930"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.29])
 by fmsmga002.fm.intel.com with SMTP; 03 May 2016 03:46:10 -0700
Received: by  (sSMTP sendmail emulation); Tue, 03 May 2016 11:46:08 +0025
Date: Tue, 3 May 2016 11:46:08 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "Mrzyglod, DanielX T" <danielx.t.mrzyglod@intel.com>,
 "Chen, Jing D" <jing.d.chen@intel.com>,
 "Zhang, Helin" <helin.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20160503104607.GA20328@bricha3-MOBL3>
References: <1460998153-187871-1-git-send-email-danielx.t.mrzyglod@intel.com>
 <1460999603-188184-1-git-send-email-danielx.t.mrzyglod@intel.com>
 <9BB6961774997848B5B42BEC655768F8E273BA@SHSMSX103.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9BB6961774997848B5B42BEC655768F8E273BA@SHSMSX103.ccr.corp.intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v2] i40e: dereference before null check
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 03 May 2016 10:46:14 -0000

On Wed, Apr 27, 2016 at 06:34:03AM +0000, Wu, Jingjing wrote:
> 
> 
> > -----Original Message-----
> > From: Mrzyglod, DanielX T
> > Sent: Tuesday, April 19, 2016 1:13 AM
> > To: Chen, Jing D; Wu, Jingjing; Zhang, Helin
> > Cc: dev@dpdk.org; Mrzyglod, DanielX T
> > Subject: [PATCH v2] i40e: dereference before null check
> > 
> > Fix issue reported by Coverity.
> > Coverity ID 13302:
> > There may be a null pointer dereference, or else the comparison against null
> > is unnecessary.
> > 
> > In i40evf_config_vlan_pvid: All paths that lead to this null pointer comparison
> > already dereference the pointer earlier
> > 
> > Fixes: 2b12431b5369 ("i40e: add vlan stripping and insertion to VF")
> > 
> > Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
> 
Applied to dpdk-next-net/rel_16_07

/Bruce