From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0097.outbound.protection.outlook.com [157.56.110.97]) by dpdk.org (Postfix) with ESMTP id C321A590B for ; Tue, 3 May 2016 14:47:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-caviumnetworks-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=eVZJgViTz4gYhBynm8cs+blqpw8isIBpwc24YMWm2cE=; b=OEkoVfkNS2TxamZYUE6BddRpUbHZRMGMW3nwI1WP6fItAKHeV9FYY5sfyPjXTbdjE66tCA33Yn+UseZzct+lB1vM9ky/hHekUlEGPHExjWTQfcT1SKaVnFH/hJCAo22PztrzPfTQspAeGHVeNT5EU9fcLoIcrGoSylVKvdMkdas= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (111.93.218.67) by CY1PR0701MB1725.namprd07.prod.outlook.com (10.163.21.14) with Microsoft SMTP Server (TLS) id 15.1.485.9; Tue, 3 May 2016 12:47:04 +0000 Date: Tue, 3 May 2016 18:16:43 +0530 From: Jerin Jacob To: "De Lara Guarch, Pablo" CC: "dev@dpdk.org" Message-ID: <20160503124642.GA9948@localhost.localdomain> References: <1462190377-26865-1-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR01CA0050.INDPRD01.PROD.OUTLOOK.COM (10.163.199.22) To CY1PR0701MB1725.namprd07.prod.outlook.com (10.163.21.14) X-MS-Office365-Filtering-Correlation-Id: 15319193-4593-400c-b2c2-08d3735107f7 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1725; 2:HZ5X0QHfQuac6Hyw2CS5BBqXC7k+YEvtzN8rkjYleBSbkM5uL2JkbWJCcQYqyPS8KTs7v4g+P07/aUBjlAhXrkr4XrxzH9LxBAzWmxrNA0sWpFedQUe7Zf7K8xnLkNc8XaFSrg4x75XM0MbH3gzK4JeYIjchhp65kzllTZJ+WZVu9XCsaCW44qY2xloyvis0; 3:+U1lAQ+EW2Eg3bZbkVSMQhtixi4rmOMoIsA1pv/h8S8teUW/6EQtXFwV85T+PF6JB4/JQBN9ZOm+l3AekokEJIYR2RY0qo76IxKKpyg1G7r0yJEGk3YCAtZzg6B6gMJz X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0701MB1725; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1725; 25:12/sidVCbm2C0pQxm8R68tT8Xh2wdldMGfMwQLfwJ/k2yeDU+ayMisQwnZYAVPGadj7/LbBVMkAdqd7uqs+9xORrxy7hsD6JJMWRCeGDqF+d5BSxagQ9WzLizn8rlMLBWxvt5Y4e2DhuMU0D5eIyXOq2I9k5v9P9cfHY8j8YaxBDWyg39DKoJqaI9RGS/MNE94qj9ppAzBFNTtA44tesDsOPo3FTmP9MUvrpPP0ORErAo3YW7CrZ4ncYXgu19McW/NacRCLahmZHo1d0ERK/bcF95PnXTZxjvsgk7ZYIW7nRD0Dhga29Rh2iCqufGZdoJeG+z1lUothpDtzXryGNmFEk2Bt60pRR1Q1wOYuR+r3j57aMwy/LbkrNbIHPUWq5kbIyrV0QwApbARRWwmZTi5SiNj290eZg4hVV9dDAy/uX2LyyT/kctmVF73juRdATTb8mFQ7JoTvih7ic/Ay+jm9zCdHG/LEt0CFmx9kOhnfcLR2fjk1AaFIsafgeWSfx5pHirqaWeiH1PpgyUJc0q/f5wShcI0HKcqMYAutGsUn8x0fiYoNLviyI66ozvRVZqjPgHdfRUZq0Y6+xmp2Iy+TYzDQ9aktDukn5W7BobDPFwAv6NcB9m0cf3z+b/J4jl43/aIZU61tJ14//nFZSvCvQV/iRiMGnucwVul52KKv9W1czo2xyqaSKNKZSNkDS3FL3X5m3DLYNFh415xTy4wnSmLjWPYn9T/x7uJWjFmPPrVQS1k9evxIRiBgmMJct31JRJtomqil6leJHdegCHQ== X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1725; 20:+fRtqVR4rg6ql55PZC+UpjQJnq2v4wJ62eMxrWvKOjaJOYODi6+TzjncTC2QEv5Y4w3YRYNDNtgTpqQwr87pfz52xCAPtXllu6kxYep/o/XRUbVRuzA2e4SwpvDiodrAsfC/rTJWI77HQrWlhtV4+hO+pA9iVbzxBtXaWgMI4CUEJuC183YiCO2IUdYRVpuV2tfhOP8DLojGzVGPE7qHxCXfk7zEOIvekwOXQz5md8Zk5J5qDYV1JsYzRffgnmuglXKcFUgmDCRcwJGx7A7iu4lgpbz7+hiAAWzfbm+I+jSBpmNNycvAkIsn0RahmGv5VGGGZ22vVLipKKUeSa3odHUeBj7g81xAkLvDnTxUIji3KPskuG7bb34oaXhyp2sWeTbxKh2z6R8MWJyQqf0TSnDdp86YWi1/BHW+bixd5xelEoTPxROOxdOl1swHKms0LF8PPopheHUflBNi45J1q0ZNWyr/ssDQAi8MvUHsb5rxyuCMhMioi0yYykuf0KvuDEKKZlCA9wZlB8AVNsv5fcWFA8Q8wefCl8o7sbDbYqHx3pUe/3f/y7cWVAyFRtN2Fx5adnt97B459kz3q01dsR9pbIfj0h/D0Irkan/bE70= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(9101521096)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:CY1PR0701MB1725; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0701MB1725; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1725; 4:EUz4FV9Gp01TVRFp7qTlT+uGUhY0KaM7DKNpeBlUPSpdbBgqXvVDNgd/NqsCLhkkm1xwosxfsXQyX72O3rIMP7cEpRpex6D06zyDy44QoOMUPt18hlXmSX7pQKeNYl2aJQyKrebeOn9T53bLuzw819NMofFWyHQMv5StqoOXwzPs0RwuI/rWM6zotxkLWJikzkAT8pdDJ+kVd+Aauwcp4ZrY9AICO5Nbof8oTtl2Hb2W6NHNeGtd4l9pglsGus6PsDsmNXlYGKcm7vH/axQlZi1P2kUt8KPZ4gGad4INwZv1gDHa+qq61pgR3n9toy2yZmDbm+J5AAB0rqwKtjpeuiXQQxe/bneqjptUC+IHAHqmygYvOEPSOdL/UVUsm6nJ7e4JdpkKip9lUtGcLe2tyw== X-Forefront-PRVS: 0931CB1479 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(13464003)(24454002)(377454003)(42186005)(9686002)(4326007)(189998001)(50466002)(47776003)(83506001)(97756001)(5009440100003)(4001350100001)(66066001)(5004730100002)(110136002)(19580405001)(46406003)(19580395003)(77096005)(2950100001)(86362001)(61506002)(54356999)(23726003)(586003)(3846002)(6116002)(5008740100001)(50986999)(33656002)(76176999)(92566002)(81166005)(1076002)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1725; H:localhost.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB1725; 23:CFFGUUgWNng74JO92vom9PEkjpR/gejYRlcyISA?= =?us-ascii?Q?6IDbErUuUiRF2AFzRDMu5rgROX1hOxN4vMtT5gxEPUlgZqzwkbDEGiKxENfb?= =?us-ascii?Q?ZPtxo21LnFoZaoGeHVuxtVNgfdN/+C//c1zJVDB0FrAIvXKRi6wv8bW3whNc?= =?us-ascii?Q?JpAzQk4kNHzHm/7mDLRoLbP1TU511vzHQOl+b8ahhH/NeXCpm3Y+OJ+OtNWm?= =?us-ascii?Q?GieNCcsCxgNljr6F9DOak4T4IVUGzjAYVN8z2KUfMUWMV8RAaPIeg4B2B63o?= =?us-ascii?Q?GdJqIkWcWDNRt7Y1XHAt4AD8vRg/BMqxPNDulmSFh361pmN//gHGdX+LbQuT?= =?us-ascii?Q?mE9hIr2AZxRKt8H9pzLQ6KItytOl20I2SCokA5Yr9HBHPUh4pFOKm3jz5/Pb?= =?us-ascii?Q?HEsWKG5+31P2KnpTHo2TK+kegZdQFVUWVnu/92CktzIv5tyTuwgp3w6XjZlg?= =?us-ascii?Q?pMQJfHUwaXAPWKmk2uGt9p6mDdBO4mom/kIgkxiuHl9nsQ0hFGcpAM/3njhW?= =?us-ascii?Q?55Qylgp4YlT/qPTHr45cOHq+vvpyFAbyNJpVWSKgumc6VpfPERQIfwZkbOEz?= =?us-ascii?Q?e1T+eH3MJR1j79u8cKdneFlDFbDQtiARYr+Mp90kWXWI2+SeGnCLxJ6ualCl?= =?us-ascii?Q?BUYUJCUAgNBqdxtZ6NWnOd9JNyhSz982fk/ha52O9RODlP5l7cfGQwZYI85j?= =?us-ascii?Q?r4KCeN6QN544cgnTX4/jsk/pMX5yTWWaPfIVrqSbfACQ82YW5G15qoMZitkV?= =?us-ascii?Q?4DhRfSKMLaMf/E9y8dsvataVuPRwT60evUexYaBH5g/HYkWEKEvLpIRbgMut?= =?us-ascii?Q?VtDGeRRkU+TkXE7QXb5p7KR713J9FSaQySVS0Jyc2PDqZwhGeOqK5OwL5gd3?= =?us-ascii?Q?HoZ5cMkEgRd4MOrRwe61l8+hwt2CQRXDt2BgMZqC0bNXY87/62FLwPKV1drd?= =?us-ascii?Q?m8abNTPRegOTYDi/YqI+xrkXFeJUNaFMVzERiWeOxth4PhWr2p78aRvdFKSC?= =?us-ascii?Q?m5kXrSoQl6rO6545f8l43E7npBxdHjlJMcl4SO8G+xOcSm4UhOW2jhVj9FZZ?= =?us-ascii?Q?kWSNol+8=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1725; 5:pLUIzlSTx2yrA+WV2tjeWOX8n4eVD88IbQOXYI/bX7GnPKsEuR0CEYWculcp8dmZukiFs/ngCp4uW6m0gEgsF3b9oKgqsyzahbgLHQk8kz4VV/DHz3eivPg1glXLcoQpWirA4P3rQ7ZH5weOwAgGlA==; 24:Q14qq+TIO4NDSN0KlMlsZauETRhn3aTdECTaUiwN607WoDf9YNLGDBmF7NTH4i3alR24qoMwY1MOOnbpMhYNyax3fKyZxtQOMHd+Fjzu0lM=; 7:gvrUfkjNQA1qw4nPc/OrOS3cAB3z+WnhCS73H1OgDij67Z8OqdoQwzyhdK9ygyMzkBlIxp/NgYhvhiGgscO9WluSixJCD+AiLTNlB1p7nDOKviSHBWX5pE75i+UTnSI/pEcYc9mvetQQGRUs6743WLMfwhUnN5sEJ0ZvfHJYqWnJs/QxETLZL/95DgRgiMum SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2016 12:47:04.0402 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1725 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add packet data prefetch in macswap loop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2016 12:47:07 -0000 On Mon, May 02, 2016 at 05:48:02PM +0000, De Lara Guarch, Pablo wrote: > Hi Jerin, > > > -----Original Message----- > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Sent: Monday, May 02, 2016 1:00 PM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo; Jerin Jacob > > Subject: [dpdk-dev] [PATCH] app/testpmd: add packet data prefetch in > > macswap loop > > > > prefetch the next packet data address in advance in macswap loop > > for performance improvement. > > > > Signed-off-by: Jerin Jacob > > --- > > app/test-pmd/macswap.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/app/test-pmd/macswap.c b/app/test-pmd/macswap.c > > index 154889d..c10f4b5 100644 > > --- a/app/test-pmd/macswap.c > > +++ b/app/test-pmd/macswap.c > > @@ -113,6 +113,9 @@ pkt_burst_mac_swap(struct fwd_stream *fs) > > if (txp->tx_ol_flags & TESTPMD_TX_OFFLOAD_INSERT_QINQ) > > ol_flags |= PKT_TX_QINQ_PKT; > > for (i = 0; i < nb_rx; i++) { > > + if (likely(i < nb_rx - 1)) > > + rte_prefetch0(rte_pktmbuf_mtod(pkts_burst[i + 1], > > + void *)); > > mb = pkts_burst[i]; > > eth_hdr = rte_pktmbuf_mtod(mb, struct ether_hdr *); > > > > -- > > 2.1.0 > > This looks good. Could you also add it in the other forwarding modes (the ones that make changes in the packets)? OK Pablo. I will add the similar logic in the following forwarding modes in testpmd. macswap macfwd macfwd-retry csumonly icmpecho /Jerin > > Thanks, > Pablo