Re: [dpdk-dev] [PATCH v2 1/4] ixgbe: rearrange vector PMD code for x86

[Bruce Richardson <bruce.richardson@intel.com>]

On Tue, Apr 26, 2016 at 09:50:40PM +0800, Jianbo Liu wrote:
> move common code to new file "ixgbe_rxtx_vec_common.h",
> and vPMD for x86 is implemented in ixgbe_rxtx_vec.c
> 
> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
> Suggested-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_rxtx_vec.c        | 256 +----------------------
>  drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 325 ++++++++++++++++++++++++++++++
>  2 files changed, 333 insertions(+), 248 deletions(-)
>  create mode 100644 drivers/net/ixgbe/ixgbe_rxtx_vec_common.h
> 
Hi Jianbo,

thanks for this, it looks a better approach to me.

However, be aware that the following commit for ixgbe code cleanup has already
been applied to the next-net/rel_16_07 branch and your patches need to take it
account:
http://dpdk.org/browse/next/dpdk-next-net/commit/?h=rel_16_07&id=3b060a97b18a88652bd401240c004f604739f6d2

Patch 1 does not apply cleanly because of this cleanup change, and, more importantly,
the cleanups are not preserved when moving the code to the new header file.
Can you please rework the patches off the top of the dpdk-next-net/rel_16_07 branch
so that we don't lose these cleanups.

Thanks,
/Bruce