From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 43A202BD5 for ; Tue, 3 May 2016 18:29:34 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 03 May 2016 09:29:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,573,1455004800"; d="scan'208";a="696200139" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.29]) by FMSMGA003.fm.intel.com with SMTP; 03 May 2016 09:29:31 -0700 Received: by (sSMTP sendmail emulation); Tue, 03 May 2016 17:29:30 +0025 Date: Tue, 3 May 2016 17:29:30 +0100 From: Bruce Richardson To: Jianbo Liu Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, helin.zhang@intel.com, konstantin.ananyev@intel.com Message-ID: <20160503162929.GA24612@bricha3-MOBL3> References: <1461159902-16680-1-git-send-email-jianbo.liu@linaro.org> <1461678643-13512-1-git-send-email-jianbo.liu@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461678643-13512-1-git-send-email-jianbo.liu@linaro.org> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 1/4] ixgbe: rearrange vector PMD code for x86 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2016 16:29:34 -0000 On Tue, Apr 26, 2016 at 09:50:40PM +0800, Jianbo Liu wrote: > move common code to new file "ixgbe_rxtx_vec_common.h", > and vPMD for x86 is implemented in ixgbe_rxtx_vec.c > > Signed-off-by: Jianbo Liu > Suggested-by: Bruce Richardson > --- > drivers/net/ixgbe/ixgbe_rxtx_vec.c | 256 +---------------------- > drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 325 ++++++++++++++++++++++++++++++ > 2 files changed, 333 insertions(+), 248 deletions(-) > create mode 100644 drivers/net/ixgbe/ixgbe_rxtx_vec_common.h > Hi Jianbo, thanks for this, it looks a better approach to me. However, be aware that the following commit for ixgbe code cleanup has already been applied to the next-net/rel_16_07 branch and your patches need to take it account: http://dpdk.org/browse/next/dpdk-next-net/commit/?h=rel_16_07&id=3b060a97b18a88652bd401240c004f604739f6d2 Patch 1 does not apply cleanly because of this cleanup change, and, more importantly, the cleanups are not preserved when moving the code to the new header file. Can you please rework the patches off the top of the dpdk-next-net/rel_16_07 branch so that we don't lose these cleanups. Thanks, /Bruce