From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 9656D137D for ; Thu, 5 May 2016 14:59:47 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 05 May 2016 05:59:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,582,1455004800"; d="scan'208";a="799513135" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.75]) by orsmga003.jf.intel.com with SMTP; 05 May 2016 05:59:44 -0700 Received: by (sSMTP sendmail emulation); Thu, 05 May 2016 13:59:43 +0025 Date: Thu, 5 May 2016 13:59:43 +0100 From: Bruce Richardson To: dev@dpdk.org Cc: thomas.monjalon@6wind.com Message-ID: <20160505125942.GA14228@bricha3-MOBL3> References: <1462379876-21901-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462379876-21901-1-git-send-email-bruce.richardson@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] eal: add missing include to debug header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2016 12:59:48 -0000 On Wed, May 04, 2016 at 05:37:56PM +0100, Bruce Richardson wrote: > The header file rte_debug.h makes use of the "unlikely" macro which > means it should include the rte_branch_prediction.h header file. > > Fixes: 50705e8e3cdd ("eal: add assert macro for debug") > > Signed-off-by: Bruce Richardson > --- > lib/librte_eal/common/include/rte_debug.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_eal/common/include/rte_debug.h b/lib/librte_eal/common/include/rte_debug.h > index 9260eda..cab6fb4 100644 > --- a/lib/librte_eal/common/include/rte_debug.h > +++ b/lib/librte_eal/common/include/rte_debug.h > @@ -44,6 +44,7 @@ > */ > > #include "rte_log.h" > +#include "rte_branch_prediction.h" > > #ifdef __cplusplus > extern "C" { Ping on this patch - any comments or concerns? It's a fairly trivial fix that prevents issues with testing some other patches on the mainline. Regards, /Bruce