From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 0404F47D0 for ; Fri, 6 May 2016 11:02:17 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 06 May 2016 02:02:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,586,1455004800"; d="scan'208";a="697691201" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.75]) by FMSMGA003.fm.intel.com with SMTP; 06 May 2016 02:02:07 -0700 Received: by (sSMTP sendmail emulation); Fri, 06 May 2016 10:02:07 +0025 Date: Fri, 6 May 2016 10:02:07 +0100 From: Bruce Richardson To: Jan Viktorin Cc: dev@dpdk.org, Thomas Monjalon , David Marchand Message-ID: <20160506090206.GA14368@bricha3-MOBL3> References: <1461935496-20367-1-git-send-email-viktorin@rehivetech.com> <1461935496-20367-5-git-send-email-viktorin@rehivetech.com> <20160505133300.GA15140@bricha3-MOBL3> <20160505190540.5e4c8422@pcviktorin.fit.vutbr.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160505190540.5e4c8422@pcviktorin.fit.vutbr.cz> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [RFC 4/4] app/test: support resources archived by tar X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2016 09:02:18 -0000 On Thu, May 05, 2016 at 07:05:40PM +0200, Jan Viktorin wrote: > On Thu, 5 May 2016 14:33:01 +0100 > Bruce Richardson wrote: > > > On Fri, Apr 29, 2016 at 03:11:36PM +0200, Jan Viktorin wrote: > > > When needing a more complex resource (a file hierarchy), packing every single > > > file as a single resource would be very ineffective. For that purpose, it is > > > possible to pack the files into a tar archive, extract it before test from the > > > resource and finally clean up all the created files. > > > > > > This patch introduces functions resource_untar and resource_rm_by_tar to > > > perform those tasks. An example of using those functions is included as a test. > > > > > > Signed-off-by: Jan Viktorin > > We might want to make this configurable on/off at build time, since it adds a new > > dependency for building dpdk - libarchive-devel. > > This is true. Unfortunately... > > Is it a problem to introduce such dependency into the test app? > Would it be help to use another similar (more spread) library (zlib)? > Not sure it would make much difference, to be honest. It all depends on what -devel packages are installed by default on most distros when you install the development tools sets. I'm not concerned too much either way, but if we add in a new dependency like this, we should also take the opportunity to turn on pcap PMD by default too and make libpcap-devel a dependency. /Bruce