From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8EE5B47CD for ; Fri, 6 May 2016 11:03:30 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 06 May 2016 02:03:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,586,1455004800"; d="scan'208";a="697691649" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.75]) by FMSMGA003.fm.intel.com with SMTP; 06 May 2016 02:03:27 -0700 Received: by (sSMTP sendmail emulation); Fri, 06 May 2016 10:03:26 +0025 Date: Fri, 6 May 2016 10:03:26 +0100 From: Bruce Richardson To: Jan Viktorin Cc: dev@dpdk.org, Thomas Monjalon , David Marchand Message-ID: <20160506090326.GB14368@bricha3-MOBL3> References: <1461935496-20367-1-git-send-email-viktorin@rehivetech.com> <20160505132930.GB14228@bricha3-MOBL3> <20160505190300.7b561cf3@pcviktorin.fit.vutbr.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160505190300.7b561cf3@pcviktorin.fit.vutbr.cz> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [RFC 0/4] Include resources in tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2016 09:03:31 -0000 On Thu, May 05, 2016 at 07:03:00PM +0200, Jan Viktorin wrote: > On Thu, 5 May 2016 14:29:30 +0100 > Bruce Richardson wrote: > > > On Fri, Apr 29, 2016 at 03:11:32PM +0200, Jan Viktorin wrote: > > > Hello, > > > > > > this patch set introduces a mechanism to include a resource (in general a blob) > > > into the test binary. This allows to make tests less dependent on the target > > > testing environment. The first use case is testing of PCI bus scan by changing > > > the hard-coded path (/sys/bus/pci/devices) to something different and provide > > > a fake tree of devices with the test. It can help with testing of device-tree > > > parsing as I've proposed in [1] where such mechanism was missing at that time. > > > I'd like to use such framework for the SoC infra testing as well. > > > > > > The patch set introduces a struct resource into the app/test. The resource is > > > generic to include any kind of binary data. The binary data can be created in > > > C or linked as an object file (created by objcopy). I am not sure where to > > > place the objcopy logic and how to perform guessing of the objcopy arguments > > > as they are pretty non-standard. > > > > > > To include a complex resource (a file hierarchy), the last patch implements > > > an archive extraction logic. So, it is possible to include a tar archive and > > > unpack it before a test starts. Any ideas how to do this in a better way are > > > welcome. > > > > > > [1] http://comments.gmane.org/gmane.comp.networking.dpdk.devel/36545 > > > > > > Regards > > > Jan Viktorin > > > > > BTW: It looks like your patch has a dependency on the 17-patch dev cleanup set from > > David, [and now on the header include bug fix I submitted yesterday too], so > > you should probably note that in any future revs of the patch you do. Save > > some head-scratching from those of us testing it out. :-) > > Hello, well, the patch set should be independent on that cleanup, so I take it as a > bug report. There should be no dependency, sorry. I'll fix it and repost. > > Thanks > Jan > It's the RTE_INIT macro is being missed otherwise. I'm trying out this new infrastructure by reworking the lpm tests to use this for the big routing table data. I'll let you know any feedback when I'm done. /Bruce