From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id DB1892B96 for ; Fri, 6 May 2016 16:29:42 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 06 May 2016 07:29:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,587,1455004800"; d="scan'208";a="947642695" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.75]) by orsmga001.jf.intel.com with SMTP; 06 May 2016 07:29:40 -0700 Received: by (sSMTP sendmail emulation); Fri, 06 May 2016 15:29:39 +0025 Date: Fri, 6 May 2016 15:29:39 +0100 From: Bruce Richardson To: John Daley Cc: dev@dpdk.org Message-ID: <20160506142938.GA8880@bricha3-MOBL3> References: <1461725415-3899-1-git-send-email-johndale@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461725415-3899-1-git-send-email-johndale@cisco.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] enic: fix 'imissed' to count drops due to no RX buffers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2016 14:29:43 -0000 On Tue, Apr 26, 2016 at 07:50:15PM -0700, John Daley wrote: > Fixes: 7182d3e7d177 ("enic: expose Rx missed packets counter") > Signed-off-by: John Daley > --- > drivers/net/enic/enic_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c > index 60fe765..be4e9e5 100644 > --- a/drivers/net/enic/enic_main.c > +++ b/drivers/net/enic/enic_main.c > @@ -243,10 +243,10 @@ void enic_dev_stats_get(struct enic *enic, struct rte_eth_stats *r_stats) > r_stats->ibytes = stats->rx.rx_bytes_ok; > r_stats->obytes = stats->tx.tx_bytes_ok; > > - r_stats->ierrors = stats->rx.rx_errors; > + r_stats->ierrors = stats->rx.rx_errors + stats->rx.rx_drop; > r_stats->oerrors = stats->tx.tx_errors; > > - r_stats->imissed = stats->rx.rx_drop; > + r_stats->imissed = stats->rx.rx_no_bufs; > > r_stats->rx_nombuf = stats->rx.rx_no_bufs; > } > -- > 2.7.0 > I think this patch just needs a little more detail in the commit message to help explain it. Can you explain what stats->rx.rx_drop is and why it should be added to ierrors rather than being part of imissed. Regards, /Bruce