* [dpdk-dev] [PATCH] enic: fix 'imissed' to count drops due to no RX buffers
@ 2016-04-27 2:50 John Daley
2016-05-06 14:29 ` Bruce Richardson
0 siblings, 1 reply; 2+ messages in thread
From: John Daley @ 2016-04-27 2:50 UTC (permalink / raw)
To: dev; +Cc: John Daley
Fixes: 7182d3e7d177 ("enic: expose Rx missed packets counter")
Signed-off-by: John Daley <johndale@cisco.com>
---
drivers/net/enic/enic_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index 60fe765..be4e9e5 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -243,10 +243,10 @@ void enic_dev_stats_get(struct enic *enic, struct rte_eth_stats *r_stats)
r_stats->ibytes = stats->rx.rx_bytes_ok;
r_stats->obytes = stats->tx.tx_bytes_ok;
- r_stats->ierrors = stats->rx.rx_errors;
+ r_stats->ierrors = stats->rx.rx_errors + stats->rx.rx_drop;
r_stats->oerrors = stats->tx.tx_errors;
- r_stats->imissed = stats->rx.rx_drop;
+ r_stats->imissed = stats->rx.rx_no_bufs;
r_stats->rx_nombuf = stats->rx.rx_no_bufs;
}
--
2.7.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] enic: fix 'imissed' to count drops due to no RX buffers
2016-04-27 2:50 [dpdk-dev] [PATCH] enic: fix 'imissed' to count drops due to no RX buffers John Daley
@ 2016-05-06 14:29 ` Bruce Richardson
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Richardson @ 2016-05-06 14:29 UTC (permalink / raw)
To: John Daley; +Cc: dev
On Tue, Apr 26, 2016 at 07:50:15PM -0700, John Daley wrote:
> Fixes: 7182d3e7d177 ("enic: expose Rx missed packets counter")
> Signed-off-by: John Daley <johndale@cisco.com>
> ---
> drivers/net/enic/enic_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
> index 60fe765..be4e9e5 100644
> --- a/drivers/net/enic/enic_main.c
> +++ b/drivers/net/enic/enic_main.c
> @@ -243,10 +243,10 @@ void enic_dev_stats_get(struct enic *enic, struct rte_eth_stats *r_stats)
> r_stats->ibytes = stats->rx.rx_bytes_ok;
> r_stats->obytes = stats->tx.tx_bytes_ok;
>
> - r_stats->ierrors = stats->rx.rx_errors;
> + r_stats->ierrors = stats->rx.rx_errors + stats->rx.rx_drop;
> r_stats->oerrors = stats->tx.tx_errors;
>
> - r_stats->imissed = stats->rx.rx_drop;
> + r_stats->imissed = stats->rx.rx_no_bufs;
>
> r_stats->rx_nombuf = stats->rx.rx_no_bufs;
> }
> --
> 2.7.0
>
I think this patch just needs a little more detail in the commit message to
help explain it. Can you explain what stats->rx.rx_drop is and why it should
be added to ierrors rather than being part of imissed.
Regards,
/Bruce
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-06 14:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-27 2:50 [dpdk-dev] [PATCH] enic: fix 'imissed' to count drops due to no RX buffers John Daley
2016-05-06 14:29 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).