From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id A152A5A7A for ; Fri, 6 May 2016 16:47:13 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP; 06 May 2016 07:47:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,587,1455004800"; d="scan'208";a="947654689" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.75]) by orsmga001.jf.intel.com with SMTP; 06 May 2016 07:47:11 -0700 Received: by (sSMTP sendmail emulation); Fri, 06 May 2016 15:47:09 +0025 Date: Fri, 6 May 2016 15:47:09 +0100 From: Bruce Richardson To: Rasesh Mody Cc: dev@dpdk.org, Dept-EngDPDKDev@qlogic.com, Harish Patil Message-ID: <20160506144709.GC8880@bricha3-MOBL3> References: <1462340302-25683-1-git-send-email-rasesh.mody@qlogic.com> <1462340302-25683-2-git-send-email-rasesh.mody@qlogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462340302-25683-2-git-send-email-rasesh.mody@qlogic.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v4 2/3] bnx2x: enhance stats get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2016 14:47:14 -0000 On Tue, May 03, 2016 at 10:38:21PM -0700, Rasesh Mody wrote: > Enhance the stats_get() routine to display drop counters under > imissed counter. > Added extended stats get support to provide additional info. > Encorporated review comment to rename some of the stats. > > Signed-off-by: Rasesh Mody > Signed-off-by: Harish Patil Again this seems to me like it should be two patches rather than one. A first patch as a fix for the drop counters and then a second patch to add the xstats functionality. Regards, /Bruce