From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D97E86CAF for ; Mon, 9 May 2016 20:02:31 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP; 09 May 2016 11:02:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,601,1455004800"; d="scan'208";a="699287487" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by FMSMGA003.fm.intel.com with ESMTP; 09 May 2016 11:02:17 -0700 Date: Mon, 9 May 2016 11:06:51 -0700 From: Yuanhan Liu To: dev@dpdk.org Cc: huawei.xie@intel.com Message-ID: <20160509180651.GD5641@yliu-dev.sh.intel.com> References: <1462224230-19460-1-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462224230-19460-1-git-send-email-yuanhan.liu@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 0/8] vhost/example cleanup/fix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2016 18:02:32 -0000 Series applied to dpdk-next-virtio. --yliu On Mon, May 02, 2016 at 02:23:42PM -0700, Yuanhan Liu wrote: > I'm starting to work on the vhost ABI refactoring, that I also have to > touch the vhost example code. The vhost example code, however, is very > messy, full of __very__ long lines. This would make a later diff to > apply the new vhost API be very ugly, therefore, not friendly for review. > This is how this cleanup comes. > > Besides that, there is one enhancement patch, which handles the broadcast > packets so that we could rely the ARP request packet, to let vhost-switch > be more like a real switch. There is another patch that (hopefully) would > fix the mbuf allocation failure ultimately. I also added some guidelines > there as comments to show how to count how many mbuf entries is enough for > our usage. > > In another word, an example is meant to be clean/simple and with good > coding style so that people can get the usage easily. So, one way or > another, this patch is good to have, even without this ABI refactoring > stuff. > > Note that I'm going to apply it before the end of this week, if no objections. > > > v2: - some checkpatch fixes > > - cleaned the code about device statistics > > --- > Yuanhan Liu (8): > examples/vhost: remove the non-working zero copy code > examples/vhost: remove unused macro and struct > examples/vhost: use tailq to link vhost devices > examples/vhost: use mac compare helper function directly > examples/vhost: handle broadcast packet > examples/vhost: fix mbuf allocation failure > examples/vhost: switch_worker cleanup > examples/vhost: embed statistics into vhost_dev struct > > doc/guides/sample_app_ug/vhost.rst | 36 +- > examples/vhost/main.c | 2394 ++++++------------------------------ > examples/vhost/main.h | 56 +- > 3 files changed, 391 insertions(+), 2095 deletions(-) > > -- > 1.9.3