From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 29625AD89 for ; Tue, 10 May 2016 16:49:42 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 10 May 2016 07:49:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,604,1455004800"; d="scan'208";a="962865082" Received: from unknown ([10.252.14.197]) by fmsmga001.fm.intel.com with SMTP; 10 May 2016 07:49:39 -0700 Received: by (sSMTP sendmail emulation); Tue, 10 May 2016 15:49:38 +0025 Date: Tue, 10 May 2016 15:49:38 +0100 From: Bruce Richardson To: Jianbo Liu Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, helin.zhang@intel.com, konstantin.ananyev@intel.com Message-ID: <20160510144937.GB14508@bricha3-MOBL3> References: <1461159902-16680-1-git-send-email-jianbo.liu@linaro.org> <1462515948-23906-1-git-send-email-jianbo.liu@linaro.org> <1462515948-23906-3-git-send-email-jianbo.liu@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462515948-23906-3-git-send-email-jianbo.liu@linaro.org> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 2/4] ixgbe: implement vector PMD for arm architecture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 May 2016 14:49:42 -0000 On Fri, May 06, 2016 at 11:55:46AM +0530, Jianbo Liu wrote: > use ARM NEON intrinsic to implement ixgbe vPMD > > Signed-off-by: Jianbo Liu > --- > drivers/net/ixgbe/Makefile | 4 + > drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 561 ++++++++++++++++++++++++++++++++ > 2 files changed, 565 insertions(+) > create mode 100644 drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c > > diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile > index 50bf51c..b1c7a60 100644 > --- a/drivers/net/ixgbe/Makefile > +++ b/drivers/net/ixgbe/Makefile > @@ -108,7 +108,11 @@ SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_rxtx.c > SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_ethdev.c > SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_fdir.c > SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_pf.c > +ifeq ($(CONFIG_RTE_ARCH_ARM64),y) > +SRCS-$(CONFIG_RTE_IXGBE_INC_VECTOR) += ixgbe_rxtx_vec_neon.c > +else > SRCS-$(CONFIG_RTE_IXGBE_INC_VECTOR) += ixgbe_rxtx_vec.c > +endif > Since you are adding ixgbe_rxtx_vec_neon.c here, it might be worthwhile adding in an extra patch to rename ixgbe_rxtx_vec.c to ixgbe_rxtx_vec_sse.c for consistency. Regards, /Bruce