From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0058.outbound.protection.outlook.com [157.56.110.58]) by dpdk.org (Postfix) with ESMTP id 384108D8B for ; Fri, 13 May 2016 10:14:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JNZnZFV++J7rK4j20ekCYOcvrEt8VBDP0dMcbdHjA7g=; b=fKj5CheEJ36anQGiRQX0S7MN9zmTuPymZUP+Fa9gDTbSKzFy71Q0A1pfxeRSWBhORmoTDNy/adKxosYLgdFzwIgPNnF6WeKQ5U2/NQk+wqa/coiGYJKcI5rLs+ZOM4YuV0q0Z7jxf8vfDxzgillkUkODeAbcWD5CCAewIbqn9kY= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (111.92.123.202) by BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) with Microsoft SMTP Server (TLS) id 15.1.497.12; Fri, 13 May 2016 08:14:31 +0000 Date: Fri, 13 May 2016 13:44:03 +0530 From: Jerin Jacob To: "Pattan, Reshma" CC: "dev@dpdk.org" , "thomas.monjalon@6wind.com" , "Richardson, Bruce" , Maciej Czekaj , Kamil Rytarowski , Zyta Szpak , Slawomir Rosek , Radoslaw Biernacki Message-ID: <20160513081402.GB4425@localhost.localdomain> References: <1462634198-2289-1-git-send-email-jerin.jacob@caviumnetworks.com> <1462634198-2289-5-git-send-email-jerin.jacob@caviumnetworks.com> <3AEA2BF9852C6F48A459DA490692831F01025933@IRSMSX109.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F01025933@IRSMSX109.ger.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [111.92.123.202] X-ClientProxiedBy: PN1PR01CA0019.INDPRD01.PROD.OUTLOOK.COM (10.164.137.26) To BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) X-MS-Office365-Filtering-Correlation-Id: 62b4b6a6-d365-404d-71c2-08d37b06a0aa X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 2:R8Gf2eKxmcYTrn56FxB77pUcLncVa4bHNgz0LI0rmb0/5v/QJ68HqMNeSOyow7Dzs1GN+ku0Sx4gVify7WEnR3ul3uDPmiabHG3lKFA9hKuvyuLMjmWx5w1n6isgHbqak0v4UO73NmL5rljyCHCGEV64oNmnuZSEZl7GH3qbcGnF3YLpFgZxGiub5l4VQmJN; 3:kKzP5wwGQH4cJwyyy7CQyQVoLSVB11Pp58cZy+8QbPyGI/R/YzOo8HWv/TVMqqcd1b5P7MUZN8yOBywUw4MlFf+NHP0xQDTfvtW1HfBUcvNF9Klf6TxlDYGSn/SZ0oMX; 25:10Q6Rdwi+og7bcJftu4COwNgzho7rTU5ltl4nlSwkPQI+k/A00C+hc7x+vqBbOOd8E4MqBv8JGj1XV3vbhoZ6E0h0ms8M/SL9LtyT93ukY9NYLu9sNAx4LVausbNhzqADw6eg8XuzbANiVOItLGhF+Yz2O6DrDHAGytFcOW1vv6mQS9+9i31ILQ+b5CVl6TfiiFai1AW7AMrfVEmbeMq54PDQr3Trcil6/OisgTWreAic3qXWQbGUc3I3CDz/CZ+nbHFCVaR9byMRvrWJetaTJ73UsSncQ6rcKItC5j0ellD5fCF/JdBLmwBk5aI+fTTcErmMNIAp6+hQvOJmALh51P54LppFrrlFj7EfhCvTayEdzZyjxJlV77+zp7PvQROpa8RCCiUumR+ey6e3Cna9BQL7Dy4kOWRJN1Wl780Zks= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 20:JbxeHZf6wteY7M+Egre4/Aqg12YzRzbqdrVDQ8d/w7bFRtiJA7bdHOnZ9kanjOnUwEzXcAFpIs2UH2ouhDA1izyc5gjuL/vjKfdrlNCjrf3R/zIIlpLGw2ZmB4RggchZ7auNNGnQ2om70s/zpoyOXbi7cL9DgsDvTJBmzvTKPwZ4VmBtvSBnWhTf1+Bc3OBCIovwpai9/dDwcY6PnoeCGaqPP2OHQXCtHkxdhd+ptL6WuxkjBJxdIbfCXr8QkRXI4mWWQJ5bVzx2qM9UsfewF90SIwrOKjoy4wd1mQ1hRGNWiMTeNik5cdL5UXDBXFnwaqhMxZRNLpdX7EhGU/V8HU9pm1VZzKZZfGTFNkCTfU+XHisGHs3cUyUNa8ZZIffYdaLOf5CsMdH2oN06Xsq9/fPFOc0zACjf5kO2n22bKlkduhboM+BQE1NY0t0NB9NP1kvnhTIM5V5vy5Gg/o1NiExrt2DyY0RGX473gwrkRx5QepclJKZN5PAWa4YRkubupBd3dE1b94k2HbMpzcZNn1omu0dZ4PKpUXQVQajGNusQdcsrpbhudgSQsJV2XeA2feR0PltxltT/2ap63feExNE0Z0KDyZVKXWK5ptJROkU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:BLUPR0701MB1715; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 4:9Q8jViqhHq3eU6BhYpgJfpiXU/U39u450iIY2g7uknWoomQVWdqQkwSgyMAhmeP4sPuuqWyrsESSwWmjtQ6GuRShTHdcNNm3BGzvmxnsWytNFVIJibUzys0mNicMAk8cVzBqiHhy5kHbq1OuVDwYCa/gE36ApIT8WvjvZ3UqpdhFua04V5rbaEcnIliil8xOZC3I7O8eoWWWDYeP27gRC90s1/coUoimmXa1k+4QplxsQIwouSyHU3NgM677OO3Op8pkPZ759QibciIcTVFK1fgttPkcot9FH1+MXl9sUI1l5OAwSjr/+RAekSZJ5k8EZnlP5Lp3MDsMT/qCV73FWm46Sn7Ksufj8AG8xEFNM+lxzROjJF/gz/rnYKi/0mWB X-Forefront-PRVS: 0941B96580 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(377454003)(13464003)(24454002)(51914003)(66066001)(189998001)(81166006)(83506001)(61506002)(6116002)(77096005)(23726003)(42186005)(3846002)(2950100001)(586003)(47776003)(4326007)(1076002)(9686002)(5004730100002)(33656002)(54356999)(5009440100003)(50986999)(50466002)(76176999)(97756001)(46406003)(4001350100001)(92566002)(5008740100001)(110136002)(19580395003)(2906002)(19580405001)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1715; H:localhost.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1715; 23:WdyR4dNiBba+yKiVQw1TwE8RG8XK14HAVJN8WDb?= =?us-ascii?Q?1IEWWdqRziEjuqJXVqp82zImWo6O0SxkDbjVqaqKolVmepXsqytJbIvodoRR?= =?us-ascii?Q?cIbdjemlUTmSjj02VZgdNazbm7z/u1g9io58hWdn+ULp61YX6vGVkTRPsTBp?= =?us-ascii?Q?UqrTyb55wI1EDzSiehvzVof/pNXhawictx2AtH9qpaitqt2yVCbdRPlSA2Mg?= =?us-ascii?Q?NiSt/khz16erbaBqR4Y0t0R1TnXPdB96118HoCoI1Q5V56wCJbfq3/pxQP1F?= =?us-ascii?Q?BbvlOGkxwp0aUoBT6WKmvOTzjWqs9z6QNNwUeivkwiFsB8LcuCfi8Thyw4CN?= =?us-ascii?Q?OUatj8NYS+Uq2LieAZ5CgG8TZdWnGtGbwsyvj0bko1MDGp2isDWcBWCamNBb?= =?us-ascii?Q?dWrgOxvCTSMAjdYkxhu+hi82nZIpeyUsonATPxAcNJB7a5gfBsAdcnQnhIXQ?= =?us-ascii?Q?KVmtQ3z7r40ckuklZR6BBlBzdCpRI2KUyluwUxEj51lxl+Q4EpwIex/Ux4jX?= =?us-ascii?Q?JmVXv+VB5W4tlKDcs6liENwTBSF097zKA/pUQGW/frh9d0YqqMHaE4hj6zau?= =?us-ascii?Q?ZiWsl1S77hLnApJ65Nysbhgt0DiUcwuG6JZyucPI0MRRQc3S5Ff/GkUCdIQ6?= =?us-ascii?Q?E2W6pX+u6KyP/GcGHRMQikYfrfsGCAi16mlONCDEGarMvLOSZnyLifuA0XSN?= =?us-ascii?Q?bh1AWrSo/GiR8ZvI5BXenV8fHeEdjbPbi4UnK83VU8IrabgzJhvJsmUEsQZV?= =?us-ascii?Q?xtDZZaFTBsJE+88hTVfKIFM1XG4T7KXjyT5JCpdoKdA9hziKAHxzbt4ktPDB?= =?us-ascii?Q?Q4HQsBJZHm9U7+EzWuhFrpxiC4bSCXnaePUgcYfKHQPita3YoyhzVE1UYEVg?= =?us-ascii?Q?0GCXHSlmPvbwCjNn52pMnLYSnzdwxZifbEn3q3bw40qssdCPuEdVTYnu9W4U?= =?us-ascii?Q?xWx6eETDjtz+a6OkkZem+bJvAXK0YSHxz2qTpl8Um5AftFYCN+MxE2byYdXH?= =?us-ascii?Q?qi3/ZMOjhDl0xWQpipO0kZphtby6YMOsf+N572FS15K+OScLo0MabAOt0tVx?= =?us-ascii?Q?Dygbs89eYOsuhxqVnu7NXGSTek/R+?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 5:sLPxkDa4PgUrTu/jCKu8uRdARE+6nXNeMo1o6JXHpmgjpDAFaNfyaI7eQeFbnOYr+LVHA91Gd5yXP+8YxwPhGPb6IBFmMymguujJv6Izx1FIVtmAQNPQ2p9a/yorESEol7+lRqVhR3+bZSj4GA/law==; 24:ZEhyvjEPLR7ToFuuPwBfldpsdlspTuKA8MFNb02GqBVV9YGKpLnAlfFvJi4UEyg2P/OsVjv45FEVK3q0j44lx8ncI5qB2DjASiARuKh+5+8=; 7:Ziu+WvIHSh4EtcpqVA6RdwflnPPxdTtzw8V3p7O1kVX5NjU9Umbka4sbmiWBWxmnopcrhZwD3OJ9IkTTO6AA3N93IQnmtu6TRIC6wifLEdFA1HjJkvnQRbkFIyiPTbQNJYP8Vs9aK4JATTQA3YiabWlJXDd6NvgdWb0yXkWnFAy61uaUUPAJk+r4OI6en+yG SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2016 08:14:31.3662 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1715 Subject: Re: [dpdk-dev] [PATCH 04/20] thunderx/nicvf: add get_reg and get_reg_length support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2016 08:14:40 -0000 On Thu, May 12, 2016 at 03:39:56PM +0000, Pattan, Reshma wrote: > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > > Sent: Saturday, May 7, 2016 4:16 PM > > To: dev@dpdk.org > > Cc: thomas.monjalon@6wind.com; Richardson, Bruce > > ; Jerin Jacob > > ; Maciej Czekaj > > ; Kamil Rytarowski > > ; Zyta Szpak > > ; Slawomir Rosek ; > > Radoslaw Biernacki > > Subject: [dpdk-dev] [PATCH 04/20] thunderx/nicvf: add get_reg and > > get_reg_length support > > > > + > > +static int > > +nicvf_dev_get_regs(struct rte_eth_dev *dev, struct rte_dev_reg_info > > +*regs) { > > + uint64_t *data = regs->data; > > + struct nicvf *nic = nicvf_pmd_priv(dev); > > + > > + if (data == NULL) > > + return -EINVAL; > > nicvf_reg_dump prints to stdout if data in NULL, so do we still want to return here? Yes as base is code common for other data plane libraries and I think in DPDK get_regs callback perspective it makes sense to add this check as PMD driver expected to get the data in the buffer. Thanks for the review. I agree with your all other review comments in another thread. Will fix it V2. > > Thanks, > Reshma > > >