From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wes1-so2.wedos.net (wes1-so2.wedos.net [46.28.106.16]) by dpdk.org (Postfix) with ESMTP id D85299AAB for ; Fri, 13 May 2016 17:36:20 +0200 (CEST) Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz [147.229.13.147]) by wes1-so2.wedos.net (Postfix) with ESMTPSA id 3r5v8h4qy3z6Y7; Fri, 13 May 2016 17:36:20 +0200 (CEST) Date: Fri, 13 May 2016 17:34:33 +0200 From: Jan Viktorin To: dev@dpdk.org Cc: Anatoly Burakov , David Marchand , Keith Wiles , Santosh Shukla , Stephen Hemminger Message-ID: <20160513173433.6c3d6e2d@pcviktorin.fit.vutbr.cz> In-Reply-To: <1461937456-22943-12-git-send-email-viktorin@rehivetech.com> References: <1461937456-22943-1-git-send-email-viktorin@rehivetech.com> <1461937456-22943-12-git-send-email-viktorin@rehivetech.com> Organization: RehiveTech MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 11/15] vfio: move global vfio_cfg to eal_vfio.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2016 15:36:21 -0000 Self review: * missing #ifdef VFIO_PRESENT ... #endif in eal_vfio.c leads to fail when VFIO build is disabled Jan On Fri, 29 Apr 2016 15:44:12 +0200 Jan Viktorin wrote: > The vfio_cfg is a module-global variable and so together with this > variable, it is necessary to move functions: > > * pci_vfio_get_group_fd > - renamed to vfio_get_group_fd > - pci_* version removed (no other call in EAL) > > * pci_vfio_setup_device > - renamed as vfio_setup_device > > * pci_vfio_enable > - renamed as vfio_enable > - generalized to check for a specific vfio driver presence > - pci_* specialization preserved as a wrapper > > * pci_vfio_is_enabled > - renamed as vfio_is_enabled > - generalized to check for a specific vfio driver presence > to preserve the semantics of VFIO + PCI > - pci_* specialization preserved as a wrapper > > * clear_current_group > - private function, just moved > > To stop GCC complaining about "defined but not used", the private > function pci_vfio_get_group_no has been removed entirely. > > Signed-off-by: Jan Viktorin > --- > lib/librte_eal/linuxapp/eal/eal_pci_init.h | 1 - > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 282 +-------------------- > lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c | 2 +- > lib/librte_eal/linuxapp/eal/eal_vfio.c | 272 ++++++++++++++++++++ > lib/librte_eal/linuxapp/eal/eal_vfio.h | 17 ++ > 5 files changed, 294 insertions(+), 280 deletions(-) [...]