From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0055.outbound.protection.outlook.com [207.46.100.55]) by dpdk.org (Postfix) with ESMTP id 2F2B86C99 for ; Thu, 19 May 2016 08:19:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=E0pzjXqgtH1ff5r4zGVn0MSE67raVjKOs+m+gp5pdHY=; b=UqRkUiqoBIid0I8JhdE61LuRkSEmVzJT41dOd1fd2jiL41PhmNlICW8b1bF2vz1NQvjD+xXFhjr5kXPeSl2lpZ0ROOXotWojNTYWeCsLG6MNFC+c6FPOvaPxNC/AlKquYaoK/w3tdnE+sO/7OtF+VXVji3/gH5uKyMT3Y+j+3cg= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (122.171.43.177) by BLUPR0701MB1716.namprd07.prod.outlook.com (10.163.85.142) with Microsoft SMTP Server (TLS) id 15.1.497.12; Thu, 19 May 2016 06:19:47 +0000 Date: Thu, 19 May 2016 11:49:26 +0530 From: Jerin Jacob To: "Mcnamara, John" CC: "dev@dpdk.org" , "thomas.monjalon@6wind.com" , "Richardson, Bruce" , Slawomir Rosek Message-ID: <20160519061921.GA3535@localhost.localdomain> References: <1462634198-2289-1-git-send-email-jerin.jacob@caviumnetworks.com> <1462634198-2289-20-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [122.171.43.177] X-ClientProxiedBy: PN1PR01CA0019.INDPRD01.PROD.OUTLOOK.COM (10.164.137.26) To BLUPR0701MB1716.namprd07.prod.outlook.com (10.163.85.142) X-MS-Office365-Filtering-Correlation-Id: a4a99f95-0d12-456a-aad3-08d37fad953f X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 2:SS0IBRKtCWr+0YQF9Dmvl3qhjxR2BaMEyadbvPeH7+v5UGoT7EMx7INVQ3sxIPIgi037YIPa1I8rc3SQXrfCyAh2XLOYP0ODr2NC4m5drbkpTQO09Aqh+VPM2nc4nWaRuZEGNtzK2hFhS4Kv5fqfz3bN1ZZsFv1MshDXNAYESHe/kSi63z1Cu0ymoOUBoDxq; 3:p5l6cRnNjU0DdTXGYDPsJYcltUHuZM+sx3ReSp9sOOdVr5fLfEgEmu56N9mFmN2ln2foeqw/6JueY0n3JSruvG61RETCPR6prWpJ7xLw+/J7rnbUhSDiMO9MaZUPuK5Z X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1716; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 25:FJDrkHk58DaNjgIznQzzkgnUkk0Dz1RmZBEt7X6PnPVnNH8NcIxaUCNNGjb4LX1RghrHL0Ype2INEQOivLR/NnSKQxL3iIb69lO7PpR5xikDppz5geJ49sQQ2u+PqTmYIOMD/gQyPOC7W1NeULkB1ktp0SHxvDZ2SYPtaxJJIHhCmG69pVGGBjS2k0kqe9if7nRIgrwPwOqYZHIu0g4lVHe65nW7d1rl8honB41SpJ70emnpHUZatl1y9hQhfYTsUlxIgUqmiVzr54LJDNy7kyhrQI7dmWo5L9wqluDd58HoPApwYoSwyb8KHskNKmEzvzQFHyxUoTkPP5lkahiTFV/4oAistMi1sKss8JIXt49Qry8E21as6TCJuWg4Be7IBq1h1TjQiXQGhqB9SmAkXgfYZwCfI8s8mybkimVWORKFhYXpOydWT/5lX+5HMWiweeHLw7KmvjrlsQpl6LsLGK+qm96uK6xidluB1R7sT+Zm7iFcbZQjehaPw/Y4Qen5U5dtiHd4xY5YRuDD6LPx8+TsLEZ2KPpaChKD99pd5P+NDV7j0HMag+lWOvJfZ4Ri+dsQ5uTFqhVhNek5p59t8slTmBJzlSn2vEXgrDWxRQ0feBHTMrb/wDt8P7A4kLjzw0cYEC1YCxcSs9fwOGjdgdC6YcvsRSB2eYnfy587Lw9yD7Drr6ApDR23BvlvBXbld9VTTmwHCTk1BWqH7CYM9cihsf2UQqc4SFqdtgzgAh9frdFMubJDTvFwaOHyLWRNZtF052dq0itWWSjKAYg5hw== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 20:wtocS3gX65lghyyST9x5sWx98JB3aLq8xinAykWCxjIooXDHRch8pM/RNmVe5DPztxocuOwGciCWuSUS6roaX8TM7+yJeZjVyK3xlD8cmPvzdmwBdvjwNadSvEUgEsG6Bq80zGomgdgTvlG+EfYXpp33msGsHmW+c8Qp3wyFazD/Hvxlff9YFjWqdNfoHVFZ0a7uoUzcATJWt5wcTForVA6nhQn4wLhWutdhepRm1GtwWx2UZNx+0WrY60iSfEoZJNbPqNZlpM6+8vAvydDK4toeZFHfmtNicV0dP9DQU+sGzteVD3oMK7u4Fqtfj+j6Ym6FTRSJOGxgVBD6lotbkmnaxTJRfMxcLltBYbJ4CZAN1mfi6eOrQz6QVC5TuuA/RD+9dyGyWyDFf+6r0YAMvjzKxwqKeBG4s+ol4zPCR9Fiu0RXfTSr940g0Jy0lNkspHh97EyZYWdxVsGSoWCGapuEhZKu4KrjUQ75pu5tudbzqhcWifUfCS9h3N69lzl9KfVkOsGS7QdZOb8+daThvBlbUetnZxfzZjrPMOM5bIfLgAXqOnUuKGEF+jtM64xRqTCUh+q/ace2xvh7x4q8QkLgdCz4IjGJzyPIHzLBTcM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:BLUPR0701MB1716; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1716; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 4:UIC8V5HHaf9TUDU5duPjw8EDc632ZOb+nxwWlnXvx1a7fe7lVp/cnpWeaNVyAr8r5kZPhF7yNebDSgJU82Hn4X8sYLuRWmCFNcwOcC7UHNrImYSdGtg17ghAVCknJs1Jw82SrpdlkEeTwXmsiVWYS21aRNJOZ7MUXGDqOiTVHWklQskBdI2AdNegvTyTOG42QgD0EFIbGeyDxyqu0VYuWxobwdBMxsjLbcAwbMnRwBX0a7G26XI3CAnk21VwZAD275PMw+FCgbwCe/mDUX4rf8gY1VlWVS8ra+MfSQchkbRW+P5KnGOIBx/txjKYHcg2sNXpBMmbeBgebakMRFckI8kJQJvR4gKJ07AWsssuihl8xL9401OiMslrWS8QGsyl X-Forefront-PRVS: 094700CA91 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(13464003)(377454003)(24454002)(9686002)(110136002)(2906002)(189998001)(5004730100002)(77096005)(2950100001)(3846002)(6116002)(97756001)(4001350100001)(5008740100001)(586003)(23726003)(50466002)(46406003)(1076002)(54356999)(50986999)(61506002)(4326007)(76176999)(92566002)(33656002)(15650500001)(19580395003)(19580405001)(66066001)(83506001)(42186005)(47776003)(8676002)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1716; H:localhost.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1716; 23:U2bwKGbbZ61nDpHGG2NjFmKiTu764ojSeyAskff?= =?us-ascii?Q?txK/UztmM0kgXoE6PdIqlYEvzyqnyNJD5+su3LeP1CutA7Pen48Dobq+yedQ?= =?us-ascii?Q?WnnpcVxYGvDe7iMaMWKFSucmpXRAKeKGfs+GXNhgP8d9NyK/SAfIWQNCPn0g?= =?us-ascii?Q?bJhjCFLZrZIUkniB5xk32ykU14BYORlZrkA1pGMmN3pchR9g1o/D8BzAygmv?= =?us-ascii?Q?cdU+f0GioTR2WXEzTdDyFOhdbQQQXeKc7UhR1ef0F2WQNvkigh1MVXqCv9z5?= =?us-ascii?Q?yKZ77mlGNxNnAGP1GQL4hPBbBlcxKXLO9730U2rrZtPP7pDv8aycPP/OUwCG?= =?us-ascii?Q?zCXBoCJRWhC5vwQa7PlcEm/Cff1EyrZTVAwZCdUGjrO+qJCevf3/qWs5I6L1?= =?us-ascii?Q?NyiQBxZ4YxK03i6ElQIvuAkB6lBSyqxAwb6bmrQkE6s42CUXWM30KPDj19pW?= =?us-ascii?Q?3qGVu26SGQvELPz+wyeJitbvqgi0rw2VG9eGABKyprbsS1o67qEJtKBJpy8K?= =?us-ascii?Q?yGnCIKGnMmOT3B8ACx+1EWCV3QnPzRTR9+7UKh7DAdgCL1KYWyPN4Gwc2TWZ?= =?us-ascii?Q?Su+PlAagQIsay+cChX2o1UP7deGzng0p6d5wF+ZAU6lf4i1feypdRYrJAN/O?= =?us-ascii?Q?ZQZG2RPTzKSQkj2WqzyaDA+PGW/5hp/PqfYQOYRKyN35Ng8RtGEMestjaigg?= =?us-ascii?Q?Xc2ylTqcjVMiUKYlKhfURd8hftJBdSFIF1b9KHsaRXUxuzjhBi+KyUne/SPi?= =?us-ascii?Q?tqYKJ+v0Mz/Y6n26gzq0NmyzqMZ2ZHhPaDn6AUHXWVNrsbm4VBLJtK//4HDN?= =?us-ascii?Q?ZPH10XSeNYJyUM9AF/KTGfY9ml4Dd+O2FQ5tXT9SR4CqJl0WMQ9yUJpb5+N3?= =?us-ascii?Q?mn5P0WKLXRf2TatF0RIDgWUJcuy3qUn2hGb69P4sX5e6wypCWx4Fq8FskX5z?= =?us-ascii?Q?Adtp8MXrDdcsrV3T4uLdiAS8YnjE19ItJSPyGFHsOFkvt6N4IZv9Hy78m1Iv?= =?us-ascii?Q?OH2NIbilquYk7Rd27opmOPW2CSVY75TO22qdIpeCcAuVM/Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 5:wDwBm7xsDIaa0M4diH1TfEFjXydeYHpjO2kSVTjJ5xOXTSoWA9tiSnKmycd4TIews3lcMV8o+F56cLjgJyGZuGFCbl8e4SEg6LcH5aLXEs7EpVJcyWTzlvGOy4+t4VnyUW6vPEuP49zg7YSmcG5XDQ==; 24:fzf/5FgrWB79vnMMCJir33gB0AIQyqb6dveKJPfqrN156Bek4Ulum3t2z6s/ttw/vocgxB1KYB+qZGrNwgMdVCGqpeWkEBeDikseHaDi+wc=; 7:iHcSb4vlqXnrr7lgDgXNjR+NbojZZftd3+/1eYYCtk8Qzr79X7HRKSptrjd8g7VqzsNk4zhtGf/8mue1TrKwku3Uxkc/5YVrk88B+XCex7S+iNB2w+KFVRMoQFDAKQOSzAxP7Vq72wlqOq43YtllMrSlF9MhMN40/OSzoSMtwZkPQkvACUMnOVHpsoEIc2ES SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2016 06:19:47.1903 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1716 Subject: Re: [dpdk-dev] [PATCH 19/20] thunderx/nicvf: updated driver documentation and release notes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2016 06:19:53 -0000 On Tue, May 17, 2016 at 04:31:58PM +0000, Mcnamara, John wrote: > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > > Sent: Saturday, May 7, 2016 4:17 PM > > To: dev@dpdk.org > > Cc: thomas.monjalon@6wind.com; Richardson, Bruce > > ; Jerin Jacob > > ; Slawomir Rosek > > > > Subject: [dpdk-dev] [PATCH 19/20] thunderx/nicvf: updated driver > > documentation and release notes > > Hi, > > Very good documentation. The content is quite clear and almost no RST issues. > The only comment is on some of the long lines. In general console blocks > have to be wrapped at 80 chars or else they go off the page in the PDF docs. > I see that you did that in some places but not in others. > > It is worth building the pdf docs to check for that: > > make doc-guides-pdf > mupdf build/doc/pdf/guides/nics.pdf & > > Some minor comments below: Thanks John for the review. Will fix it in v2. > > > > + > > +#. Start ``testpmd`` with basic parameters: > > + > > + .. code-block:: console > > + > > + ./arm64-thunderx-linuxapp-gcc/app/testpmd -c 0xf -n 4 -w > > + 0002:01:00.2 -- -i --disable-hw-vlan-filter --crc-strip --no-flush-rx > > + --port-topology=loop > > Would be better wrapped as something like this: > > .. code-block:: console > > ./arm64-thunderx-linuxapp-gcc/app/testpmd -c 0xf -n 4 -w 0002:01:00.2 \ > -- -i --disable-hw-vlan-filter --crc-strip --no-flush-rx > --port-topology=loop > > > > + > > + Example output: > > + > > + .. code-block:: console > > + > > + ... > > + > > + PMD: rte_nicvf_pmd_init(): librte_pmd_thunderx nicvf version 1.0 > > + > > + ... > > + EAL: probe driver: 177d:11 rte_nicvf_pmd > > + EAL: using IOMMU type 1 (Type 1) > > + EAL: PCI memory mapped at 0x3ffade50000 > > + EAL: Trying to map BAR 4 that contains the MSI-X table. Trying > > offsets: 0x40000000000:0x0000, 0x10000:0x1f0000 > > + EAL: PCI memory mapped at 0x3ffadc60000 > > + PMD: nicvf_eth_dev_init(): nicvf: device (177d:11) 2:1:0:2 > > + PMD: nicvf_eth_dev_init(): node=0 vf=1 mode=tns-bypass sqs=false > > loopback_supported=true > > + PMD: nicvf_eth_dev_init(): Port 0 (177d:11) mac=a6:c6:d9:17:78:01 > > + Interactive-mode selected > > + Configuring Port 0 (socket 0) > > > Also, this should be wrapped (even though it is the actual output): > > ... > EAL: probe driver: 177d:11 rte_nicvf_pmd > EAL: using IOMMU type 1 (Type 1) > EAL: PCI memory mapped at 0x3ffade50000 > EAL: Trying to map BAR 4 that contains the MSI-X table. > Trying offsets: 0x40000000000:0x0000, 0x10000:0x1f0000 > EAL: PCI memory mapped at 0x3ffadc60000 > PMD: nicvf_eth_dev_init(): nicvf: device (177d:11) 2:1:0:2 > PMD: nicvf_eth_dev_init(): node=0 vf=1 mode=tns-bypass sqs=false > loopback_supported=true > PMD: nicvf_eth_dev_init(): Port 0 (177d:11) mac=a6:c6:d9:17:78:01 > Interactive-mode selected > Configuring Port 0 (socket 0) > ... > > > > +SR-IOV: Prerequisites and sample Application Notes > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > + > > +Current ThunderX NIC PF/VF kernel modules maps each physical Ethernet > > +port automatically to virtual function (VF) and presented as PCIe-like > > SR-IOV device. > > > Slightly better as: > > Current ThunderX NIC PF/VF kernel modules maps each physical Ethernet port > automatically to virtual functions (VF) and presents them as PCIe-like SR-IOV device. > > > > + Example qemu guest launch command: > > + > > + .. code-block:: console > > + > > + sudo qemu-system-aarch64 -name vm1 -machine > > virt,gic_version=3,accel=kvm,usb=off \ > > + -cpu host -m 4096 \ > > + -smp 4,sockets=1,cores=8,threads=1 \ > > + -nographic -nodefaults \ > > + -kernel \ > > Also wrap the first line: > > .. code-block:: console > > sudo qemu-system-aarch64 -name vm1 \ > -machine virt,gic_version=3,accel=kvm,usb=off \ > -cpu host -m 4096 \ > ... > > > Apart from those small changes: > > Acked-by: John McNamara > > > >