From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id B0E6C530F for ; Tue, 24 May 2016 15:21:21 +0200 (CEST) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1b5CGj-0006yi-Se; Tue, 24 May 2016 09:21:19 -0400 Date: Tue, 24 May 2016 09:21:03 -0400 From: Neil Horman To: Panu Matilainen Cc: dev@dpdk.org, Bruce Richardson , Thomas Monjalon , Stephen Hemminger Message-ID: <20160524132103.GA6721@hmsreliant.think-freely.org> References: <1463431287-4551-1-git-send-email-nhorman@tuxdriver.com> <1463765086-17349-1-git-send-email-nhorman@tuxdriver.com> <1463765086-17349-3-git-send-email-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCHv3 2/5] drivers: Update driver registration macro usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2016 13:21:21 -0000 On Tue, May 24, 2016 at 09:57:35AM +0300, Panu Matilainen wrote: > On 05/20/2016 08:24 PM, Neil Horman wrote: > > Modify the PMD_REGISTER_DRIVER macro, adding a name argument to it. The > > addition of a name argument creates a token that can be used for subsequent > > macros in the creation of unique symbol names to export additional bits of > > information for use by the pmdinfogen tool. For example: > > > > PMD_REGISTER_DRIVER(ena_driver, ena); > > > [..] > > diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c > > index 071b44f..ee9581b 100644 > > --- a/drivers/net/bnx2x/bnx2x_ethdev.c > > +++ b/drivers/net/bnx2x/bnx2x_ethdev.c > > @@ -550,5 +550,7 @@ static struct rte_driver rte_bnx2xvf_driver = { > > .init = rte_bnx2xvf_pmd_init, > > }; > > > > -PMD_REGISTER_DRIVER(rte_bnx2x_driver); > > -PMD_REGISTER_DRIVER(rte_bnx2xvf_driver); > > +PMD_REGISTER_DRIVER(rte_bnx2x_driver, pci_id_bnx2x_map, bnx2x); > > +DRIVER_EXPORT_PCI_TABLE(bnx2x, pci_id_bnx2x_map); > > +PMD_REGISTER_DRIVER(rte_bnx2xvf_driver, pci_id_bnx2xvf_map, bnx2xvf); > > +DRIVER_EXPORT_PCI_TABLE(bnx2xvf, pci_id_bnx2xvf_map); > > There are extra arguments to PMD_REGISTER_DRIVER() here, causing build > failure. Its easy to miss since bnx2x doesn't get built by default, dunno if > it was in earlier versions already (if it was, sorry for missing it). > Shoot, you're right, the middle argument should be removed, and I didn't catch it because bnx2x isn't built by default, and I thought it was. I'll fix that up Neil > - Panu - >